-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rating] Use fieldset instead of span for the root element #44181
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewhttps://deploy-preview-44181--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Just curious, won't this be a breaking change for users who targets |
Yep, it could break some apps. I was checking to see what it would take to make the change. It improves the accessibility tough. Maybe as a first step we can introduce a |
Yup, sure. I'll open |
Using fieldset as a root of the Rating improves the a11y, as the component wraps multiple inputs with labels. I had to add some minimal styles to get to the same look as before.
On another note, while working on it, I noticed that we don't support the component prop here. I can add it in a separate PR, to allow people to opt into the old behavior if needed for some reason.