Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Remove axis from the pie chart #15187

Merged
merged 3 commits into from
Nov 4, 2024
Merged

[charts] Remove axis from the pie chart #15187

merged 3 commits into from
Nov 4, 2024
+3 −165

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Oct 30, 2024 •
edited by JCQuintas
Loading

Changelog

  • The Pie Chart lost all props and render linked to axes because pie chart does not need cartesian axes. If you used it, you can still add them back with composition. Please consider opening an issue to share your use case with us.

@alexfauquette alexfauquette added breaking change component: charts This is the name of the generic UI component, not the React module! labels Oct 30, 2024
@mui-bot
Copy link

mui-bot commented Oct 30, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15187--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b62b817

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Oct 30, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #15187 will not alter performance

Comparing alexfauquette:remove-pie-axes (b62b817) with master (1ca98d3)

Summary

✅ 3 untouched benchmarks

@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 30, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 4, 2024
@alexfauquette alexfauquette merged commit 26ee378 into mui:master Nov 4, 2024
19 checks passed
@alexfauquette alexfauquette deleted the remove-pie-axes branch November 4, 2024 16:10
@alexfauquette alexfauquette mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JCQuintas JCQuintas JCQuintas approved these changes

Assignees
No one assigned
Labels
breaking change component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexfauquette @mui-bot @JCQuintas