Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add charts migration guide #15276

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@alexfauquette alexfauquette added docs Improvements or additions to the documentation component: charts This is the name of the generic UI component, not the React module! labels Nov 5, 2024
@mui-bot
Copy link

mui-bot commented Nov 5, 2024

Copy link

codspeed-hq bot commented Nov 5, 2024

CodSpeed Performance Report

Merging #15276 will not alter performance

Comparing alexfauquette:migration-guide (c41b3ae) with master (4c11e44)

Summary

✅ 3 untouched benchmarks

Comment on lines +74 to +80
Some properties got deprecated in v7 in favor of a more consistent naming convention.
Those deprecated properties got removed in v8.

The impacted properties are:

- The `xAxisKey`, `yAxisKey`, and `zAxisKey` are renamed `xAxisId`, `yAxisId`, and `zAxisId`.
- The `highlighted` and `faded` properties of `series.highlightScope` are renamed `highlight` and `fade`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no codemod for this yet right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because I assume few people do

<LineChart
  series={[{ data: [ ... ], xAxisKey: 'axis1', highlightScope: { highlight: 'series' } }]}
/>

In our realistic demo we always move those information in distinct part, like

const highlightScope = { highlight: 'series' };

<LineChart
  series={[{ data: [ ... ], xAxisKey: 'axis1', highlightScope }]}
/>

// or even

const series= [
  { ...}
].map(...)

<LineChart
  series={series}
  { /* ... */ }
/>

Comment on lines +92 to +95
## Remove Pie Chart axes

The `<PieChart />` got by error the code to render axes.
This code is removed in v8, which implies removing the following props: `axisHighlight`, `topAxis`, `rightAxis`, `bottomAxis`, and `leftAxis`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for this one I assume nobody used those

@JCQuintas
Copy link
Member

Should @samuelsycamore review these? 🤔

@alexfauquette
Copy link
Member Author

Should @samuelsycamore review these? 🤔

Yes, but we could merge before the release such that use get the information everywhere (the changelog and migration docs)

This page will evolve a lot in the coming month since every breaking change PR will add something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants