Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Remove deprecated highlight properties #15191

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

alexfauquette
Copy link
Member

Changelog

The highlighted and faded properties of highlightScope were deprecated in favor of highlight and fade.
The deprecated ones are now removed.

@alexfauquette alexfauquette added breaking change component: charts This is the name of the generic UI component, not the React module! labels Oct 30, 2024
@mui-bot
Copy link

mui-bot commented Oct 30, 2024

Deploy preview: https://deploy-preview-15191--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 57affbc

Copy link

codspeed-hq bot commented Oct 30, 2024

CodSpeed Performance Report

Merging #15191 will not alter performance

Comparing alexfauquette:rename-highlights (57affbc) with master (26ee378)

Summary

✅ 3 untouched benchmarks

Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

docs/data/charts/bars/BarAnimation.tsx Outdated Show resolved Hide resolved
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you plan to add a section to the migration guide?
And maybe a codemod?

@alexfauquette
Copy link
Member Author

alexfauquette commented Nov 5, 2024

@flaviendelangle This issue with codemod is that it's nested properties. So I assume (at least that's how I would do it in my apps) that those definition are made outside. So a codemod would catch few usecases.

Yes for the migration guide, but I will open a dedicated PR for all the renaming we merged this week #15276

@alexfauquette alexfauquette merged commit 4c11e44 into mui:master Nov 5, 2024
19 checks passed
@alexfauquette alexfauquette deleted the rename-highlights branch November 5, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants