Fix github actions for SingleStore and code coverage #138
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=======================================
Coverage 73.83% 73.83%
=======================================
Files 12 12
Lines 1261 1261
=======================================
Hits 931 931
Misses 267 267
Partials 63 63
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -53,9 +57,11 @@ | |||
| run: go test -coverprofile=coverage.txt -covermode=atomic -coverpkg=github.com/muir/libschema/... ./lsmysql/... ./lssinglestore/... | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2 | |||
| uses: codecov/codecov-action@v4 | |||
Check warning
Code scanning / Semgrep (reported by Codacy)
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning
| @@ -60,9 +60,11 @@ | |||
| run: go test -coverprofile=coverage.txt -covermode=atomic -coverpkg=github.com/muir/libschema/... ./lsmysql/... | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2 | |||
| uses: codecov/codecov-action@v4 | |||
Check warning
Code scanning / Semgrep (reported by Codacy)
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning
| @@ -24,8 +24,10 @@ | |||
| run: make calculate_coverage | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2 | |||
| uses: codecov/codecov-action@v4 | |||
Check warning
Code scanning / Semgrep (reported by Codacy)
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning
| @@ -58,8 +58,10 @@ | |||
| run: go test -coverprofile=coverage.txt -covermode=atomic -coverpkg=github.com/muir/libschema/... ./lspostgres/... | |||
|
|
|||
| - name: Upload coverage to Codecov | |||
| uses: codecov/codecov-action@894ff025c7b54547a9a2a1e9f228beae737ad3c2 | |||
| uses: codecov/codecov-action@v4 | |||
Check warning
Code scanning / Semgrep (reported by Codacy)
An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning
| @@ -29,7 +29,11 @@ jobs: | |||
|
|
|||
| - name: sanity check using mysql client | |||
| run: | | |||
| mysql -u root -ptest -e "CREATE DATABASE libschematest" -h 127.0.0.1 | |||
| mysql -u root -ptest -e "CREATE DATABASE libschematest partitions 2" -h 127.0.0.1 | |||
There was a problem hiding this comment.
I also adjust snapshots and minimal disk. Useful?
| @@ -185,7 +185,7 @@ func (p *SingleStore) CreateSchemaTableIfNotExists(ctx context.Context, _ *inter | |||
| } | |||
| if schema != "" { | |||
| _, err := d.DB().ExecContext(ctx, fmt.Sprintf(` | |||
| CREATE DATABASE IF NOT EXISTS %s | |||
| CREATE DATABASE IF NOT EXISTS %s PARTITIONS 2 | |||
There was a problem hiding this comment.
Does it make sense that the database where store the set of migrations that have run should have 2 partitions in production?
It's only accessed during program startup and is very tiny.
There was a problem hiding this comment.
Yeah, if it's really small, 2 partitions is the way to go (it does mean that database shouldn't be used for anything else), since that's the minimum singlestore supports today.
muir
changed the title
This fixes the SingleStore tests on Github Actions
It fixes codecov uploading