Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the playright tests and the jupyter "pre" tests #1293

Merged
merged 5 commits into from
Dec 15, 2024
Merged

Conversation

mwouts
Copy link
Owner

@mwouts mwouts commented Dec 15, 2024

The automated update fails, and I could not run the update locally neither.

Relates to #1294

Copy link

Thank you for making this pull request.

Did you know? You can try it on Binder: Binder:lab or Binder:notebook.

Also, the version of Jupytext developed in this PR can be installed with pip:

HATCH_BUILD_HOOKS_ENABLE=true pip install git+https://github.com/mwouts/jupytext.git@fix_playright_tests

(this requires nodejs, see more at Developing Jupytext)

Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.05%. Comparing base (a577661) to head (4b4881a).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1293      +/-   ##
==========================================
+ Coverage   95.51%   97.05%   +1.54%     
==========================================
  Files          29       29              
  Lines        4479     4479              
==========================================
+ Hits         4278     4347      +69     
+ Misses        201      132      -69     
Flag Coverage Δ
external 75.02% <ø> (?)
functional 88.55% <ø> (?)
integration 77.25% <ø> (?)
unit 66.56% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mwouts mwouts force-pushed the fix_playright_tests branch 2 times, most recently from f6aecde to ade6a31 Compare December 15, 2024 12:45
@mwouts mwouts changed the title Skip the playright tests Skip the playright tests and the jupyter "pre" tests Dec 15, 2024
@mwouts mwouts marked this pull request as ready for review December 15, 2024 12:45
@mwouts mwouts force-pushed the fix_playright_tests branch from ade6a31 to f18a855 Compare December 15, 2024 13:28
@mwouts mwouts force-pushed the fix_playright_tests branch from f18a855 to 4b4881a Compare December 15, 2024 14:26
@mwouts mwouts merged commit 5775191 into main Dec 15, 2024
32 checks passed
@mwouts mwouts deleted the fix_playright_tests branch December 15, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant