Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip the playright tests and the jupyter "pre" tests #1293

Merged
merged 5 commits into from
Dec 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/step_tests-conda.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ jobs:
# Check extension
jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "jupyterlab-jupytext.*OK"
python -m jupyterlab.browser_check

# Commented out on Dec 15, 2024, until we can fix that test
# python -m jupyterlab.browser_check

- name: Upload coverage
uses: codecov/codecov-action@v3
Expand Down
11 changes: 6 additions & 5 deletions .github/workflows/step_tests-pip.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@ jobs:
python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12", "3.13"]
experimental: [false]
include:
# Test pre-release versions
- python-version: "3.x"
dependency_type: "pre"
experimental: false
# Test minimum markdown-it-py supported (otherwise the most recent version is used)
- python-version: "3.x"
markdown-it-py: "~=2.0"
Expand Down Expand Up @@ -62,6 +58,9 @@ jobs:
jupyterlab
${{ format('markdown-it-py{0}', matrix.markdown-it-py) }}

- name: List the versions of the Jupyter components
run: jupyter --version

- name: Install a Jupyter Kernel
if: ${{ !matrix.no_kernel }}
run: python -m ipykernel install --name python_kernel --user
Expand Down Expand Up @@ -97,7 +96,9 @@ jobs:
# Check extension
jupyter labextension list
jupyter labextension list 2>&1 | grep -ie "jupyterlab-jupytext.*OK"
python -m jupyterlab.browser_check

# Commented out on Dec 15, 2024, until we can fix that test
# python -m jupyterlab.browser_check

- name: Upload coverage
uses: codecov/codecov-action@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/step_tests-ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
run: jlpm playwright install chromium

- name: Integration tests
# https://github.com/mwouts/jupytext/issues/1294
if: false
working-directory: jupyterlab/packages/jupyterlab-jupytext-extension/ui-tests
run: jlpm playwright test

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-playwright-snapshots.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
# Test folder within your repository
test_folder: ../playwright-tests
test_folder: playwright-tests

# Optional npm scripts (the default values are displayed)
# Script to start the server or 'null' if Playwright is taking care of it
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Jupytext ChangeLog

**Fixed**
- The `rst2md` tests have been fixed by requiring `sphinx<8` ([#1266](https://github.com/mwouts/jupytext/issues/1266))
- Some dependencies of the JupyterLab extensions were updated ([#1272](https://github.com/mwouts/jupytext/issues/1272), [#1273](https://github.com/mwouts/jupytext/issues/1273), [#1280](https://github.com/mwouts/jupytext/issues/1280), [#1285](https://github.com/mwouts/jupytext/issues/1285), [#1290](https://github.com/mwouts/jupytext/issues/1290))

**Added**
- Jupytext is now tested with Python 3.13 ([#1242](https://github.com/mwouts/jupytext/issues/1242)). Thanks to [Jerry James](https://github.com/jamesjer) for the suggested fixes!
Expand Down
Loading