[Bexley] Garden subscription flow, front to payment. #5325
Merged
+450
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bexley-ww-garden-reviewed #5325 +/- ##
==========================================================
Coverage 82.46% 82.47%
==========================================================
Files 417 418 +1
Lines 33017 33025 +8
Branches 5313 5313
==========================================================
+ Hits 27228 27237 +9
- Misses 4218 4219 +1
+ Partials 1571 1569 -2 ☔ View full report in Codecov by Sentry. |
davea
approved these changes
Jan 21, 2025
davea
force-pushed
the
bexley-ww-pre-work-refactor-2
branch
2 times, most recently
from
7210735 to
da1a1df
Compare
TODO lots more probably. It does not know until you have picked DD/CC that DD is cheaper for the first bin. Perhaps can be implemented as a 5GBP discount when you click the DD option?
davea
force-pushed
the
bexley-ww-garden-subscription
branch
from
b2518f4 to
6a422df
Compare
davea
changed the base branch from
bexley-ww-pre-work-refactor-2
to
bexley-ww-garden-reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #5324 - with that and the #5322 refactor, basic garden subscription itself is hopefully not too much as you can see, is mostly a test!
With the configuration given in https://github.com/mysociety/societyworks/issues/4613, and a "Garden Subscription" category with payment/payment_method/uprn/property_id extra fields, and not with garden_disabled, with this PR you should be able to get through a subscription sign up from bin day page link in right sidebar to the details page, and with SCP (public) or Paye (staff) payment. It should then confirm and create a report for then sending to Agile (not storing any extra data as yet, see TODOs in the test).
[skip changelog]