Skip to content

perf: simplify pandas-like with_columns #7492

perf: simplify pandas-like with_columns

perf: simplify pandas-like with_columns #7492

Triggered via pull request November 13, 2024 10:52
Status Success
Total duration 13s
Artifacts

release-drafter.yml

on: pull_request
update_release_draft
4s
update_release_draft
Fit to window
Zoom out
Zoom in

Annotations

3 errors
update_release_draft
Resource not accessible by integration { name: 'HttpError', id: '11815763794', status: 403, response: { url: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1366/labels', status: 403, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-encoding': 'gzip', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Wed, 13 Nov 2024 10:52:38 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'github.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', 'transfer-encoding': 'chunked', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'issues=write; pull_requests=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': '901D:1AEEF3:7FD06B1:F993B0F:673484F6', 'x-ratelimit-limit': '5000', 'x-ratelimit-remaining': '4796', 'x-ratelimit-reset': '1731496324', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '204', 'x-xss-protection': '0' }, data: { message: 'Resource not accessible by integration', documentation_url: 'https://docs.github.com/rest/issues/labels#add-labels-to-an-issue', status: '403' } }, request: { method: 'POST', url: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1366/labels', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.13.1 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"labels":["performance"]}', request: {} }, event: { id: '11815763794', name: 'pull_request', payload: { action: 'edited', changes: { body: { from: 'Looks like we no longer need the specialised path, I think https://github.com/narwhals-dev/narwhals/pull/1201/files may have made it redundant\r\n' + '\r\n' + 'This passes all unit and downstream tests. I also ran the scikit-lego test suite manually locally to make sure (as it was there that we noticed the need for a separate path), and can confirm it still passes\r\n' + '\r\n' + "If anyone's reviewing, this is much easier to review hiding whitespace https://github.com/narwhals-dev/narwhals/pull/1366/files?diff=unified&w=1\r\n" + '\r\n' + '<!--\r\n' + '# Thanks for contributing a pull request! \r\n' + '## Please make sure you see our contribution guidelines: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md\r\n' + '-->\r\n' + '\r\n' + '## What type of PR is this? (check all applicable)\r\n' + '\r\n' + '- [ ] 💾 Refactor\r\n' + '- [ ] ✨ Feature\r\n' + '- [ ] 🐛 Bug Fix\r\n' + '- [ ] 🔧 Optimization\r\n' + '- [ ] 📝 Documentation\r\n' + '- [ ] ✅ Test\r\n' + '- [ ] 🐳 Other\r\n' + '\r\n' + '## Related issues \r\n' + '\r\n' + '- Related issue # \r\n' + '- Closes #\r\n' + '\r\n' + '## Checklist\r\n' + '\r\n' + '- [ ] Code follows style guide (ruff)\r\n' + '- [ ] Tests added \r\n' + '- [ ] Documented the changes\r\n' + '\r\n' + '## If you have comment
update_release_draft
Resource not accessible by integration { name: 'HttpError', id: '11815763794', status: 403, response: { url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases', status: 403, headers: { 'access-control-allow-origin': '*', 'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset', connection: 'close', 'content-encoding': 'gzip', 'content-security-policy': "default-src 'none'", 'content-type': 'application/json; charset=utf-8', date: 'Wed, 13 Nov 2024 10:52:40 GMT', 'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin', server: 'github.com', 'strict-transport-security': 'max-age=31536000; includeSubdomains; preload', 'transfer-encoding': 'chunked', vary: 'Accept-Encoding, Accept, X-Requested-With', 'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write', 'x-content-type-options': 'nosniff', 'x-frame-options': 'deny', 'x-github-api-version-selected': '2022-11-28', 'x-github-media-type': 'github.v3; format=json', 'x-github-request-id': '9020:1807:EF26A5:1D6EA2A:673484F8', 'x-ratelimit-limit': '5000', 'x-ratelimit-remaining': '4789', 'x-ratelimit-reset': '1731496324', 'x-ratelimit-resource': 'core', 'x-ratelimit-used': '211', 'x-xss-protection': '0' }, data: { message: 'Resource not accessible by integration', documentation_url: 'https://docs.github.com/rest/releases/releases#create-a-release', status: '403' } }, request: { method: 'POST', url: 'https://api.github.com/repos/narwhals-dev/narwhals/releases', headers: { accept: 'application/vnd.github.v3+json', 'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.13.1 (linux; x64)', authorization: 'token [REDACTED]', 'content-type': 'application/json; charset=utf-8' }, body: '{"target_commitish":"refs/pull/1366/merge","name":"Narwhals v1.13.5","tag_name":"","body":"## Changes\\n\\n## ✨ Enhancements\\n\\n- feat: add `DataFrame.pivot` for pandas like and Polars backend (#546)\\n\\n## 🐞 Bug fixes\\n\\n- fix: pandas and arrow `to_dummies` with nulls (#1040)\\n\\n## 🛠️ Other improvements\\n\\n- test: unxfail `test_to_dummies_drop_first_na` for cudf (#1364)\\n- chore: More typing in _polars (#1363)\\n- chore: Improve typing in _polars/utils (#1358)\\n- chore: add issue_deprecation_warning to generate_unique_token function (#1359)\\n\\nThank you to all our contributors for making this release possible!\\n@FBruzzesi, @MUKESHRAJMAHENDRAN, @MarcoGorelli and @raisadz\\n","draft":true,"prerelease":false,"make_latest":"true"}', request: { retryCount: 1 } }, event: { id: '11815763794', name: 'pull_request', payload: { action: 'edited', changes: { body: { from: 'Looks like we no longer need the specialised path, I think https://github.com/narwhals-dev/narwhals/pull/1201/files may have made it redundant\r\n' + '\r\n' + 'This passes all unit and downstream tests. I also ran the scikit-lego test suite manually locally to make sure (as it was there that we noticed the need for a separate path), and can confirm it still passes\r\n' + '\r\n' + "If anyone's reviewing, this is much easier to review hiding whitespace https://github.com/narwhals-dev/narwhals/pull/1366/files?diff=unified&w=1\r\n" + '\r\n' + '<!--\r\n' + '# Thanks for contributing a pull request! \r\n' + '## Please make sure you see our contribution guidelines: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md\r\n' + '-->\r\n' + '\r\n' + '## What type of PR is this? (check all ap
update_release_draft
HttpError: Resource not accessible by integration at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18) HttpError: Resource not accessible by integration at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18) { name: 'AggregateError', event: { id: '11815763794', name: 'pull_request', payload: { action: 'edited', changes: { body: { from: 'Looks like we no longer need the specialised path, I think https://github.com/narwhals-dev/narwhals/pull/1201/files may have made it redundant\r\n' + '\r\n' + 'This passes all unit and downstream tests. I also ran the scikit-lego test suite manually locally to make sure (as it was there that we noticed the need for a separate path), and can confirm it still passes\r\n' + '\r\n' + "If anyone's reviewing, this is much easier to review hiding whitespace https://github.com/narwhals-dev/narwhals/pull/1366/files?diff=unified&w=1\r\n" + '\r\n' + '<!--\r\n' + '# Thanks for contributing a pull request! \r\n' + '## Please make sure you see our contribution guidelines: https://github.com/narwhals-dev/narwhals/blob/main/CONTRIBUTING.md\r\n' + '-->\r\n' + '\r\n' + '## What type of PR is this? (check all applicable)\r\n' + '\r\n' + '- [ ] 💾 Refactor\r\n' + '- [ ] ✨ Feature\r\n' + '- [ ] 🐛 Bug Fix\r\n' + '- [ ] 🔧 Optimization\r\n' + '- [ ] 📝 Documentation\r\n' + '- [ ] ✅ Test\r\n' + '- [ ] 🐳 Other\r\n' + '\r\n' + '## Related issues \r\n' + '\r\n' + '- Related issue # \r\n' + '- Closes #\r\n' + '\r\n' + '## Checklist\r\n' + '\r\n' + '- [ ] Code follows style guide (ruff)\r\n' + '- [ ] Tests added \r\n' + '- [ ] Documented the changes\r\n' + '\r\n' + '## If you have comments or can explain your changes, please do so below.\r\n' + '\r\n' } }, number: 1366, organization: { avatar_url: 'https://avatars.githubusercontent.com/u/169070048?v=4', description: 'Narwhals developers', events_url: 'https://api.github.com/orgs/narwhals-dev/events', hooks_url: 'https://api.github.com/orgs/narwhals-dev/hooks', id: 169070048, issues_url: 'https://api.github.com/orgs/narwhals-dev/issues', login: 'narwhals-dev', members_url: 'https://api.github.com/orgs/narwhals-dev/members{/member}', node_id: 'O_kgDOChPN4A', public_members_url: 'https://api.github.com/orgs/narwhals-dev/public_members{/member}', repos_url: 'https://api.github.com/orgs/narwhals-dev/repos', url: 'https://api.github.com/orgs/narwhals-dev' }, pull_request: { _links: { comments: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1366/comments' }, commits: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/1366/commits' }, html: { href: 'https://github.com/narwhals-dev/narwhals/pull/1366' }, issue: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/issues/1366' }, review_comment: { href: 'https://api.github.com/repos/narwhals-dev/narwhals/pulls/comments{/number}' }, review_comments: {