chore: Factor out _polars from top-level Narwhals modules (i.e.: the mother of all refactors!) #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Jul 20, 2024
Comment on lines
3131
to
3132
| def func(plx: Any) -> Any: | ||
| if ( | ||
| (pl := get_polars()) is not None | ||
| and plx is pl | ||
| and parse_version(pl.__version__) <= (0, 20, 4) | ||
| ): # pragma: no cover | ||
| return plx.count().alias("len") | ||
| return plx.len() |
There was a problem hiding this comment.
finally...that was really dirty, so glad we've finally got a better way
MarcoGorelli
commented
Jul 20, 2024
Comment on lines
-88
to
-93
| def validate_same_library(items: Iterable[Any]) -> None: | ||
| if all(item._is_polars for item in items): | ||
| return | ||
| if all(hasattr(item._compliant_frame, "_implementation") for item in items) and ( | ||
| len({item._compliant_frame._implementation for item in items}) == 1 | ||
| ): |
There was a problem hiding this comment.
this function's good, it's just going to be intractable to enforce the "same-library-constraint" everywhere...rather than rewrite it, I'd prefer to just not bother
trying to compare different libraries raises an error anyway, it doesn't do something dangerous like silently give wrong results
|
what this achives:
but hopefully, it makes the project easier to understand, and most importantly, easy to contribute to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.