Fix isThrottlingException function to check error name #3798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cumulus-bot
changed the base branch from
master
to
ecarton/hailian-fix-sfEventSqsToDbRecords
cumulus-bot
merged commit 29ad619
into
nasa:ecarton/hailian-fix-sfEventSqsToDbRecords
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR addresses an issue in
SfEventSqsToDbRecordsthat causes certain portion of granule records not from getting updated in the Cumulus database and CloudMetrics during high-throughput ingestion.This PR has been tested in the GES DISC Cumulus UAT. Previously, > 20% of granule records were missed from the Cumulus database and CloudMetrics. After implementing the changes from this PR, no granule records were lost.
NOTE: I don't see any existing unit tests associated with the
isThrottlingExceptionfunction that is being modified in this PR. Please let me know if I missed something. Thanks!Addresses Github issue 3796: Granule records missing from CloudMetrics
Changes
isThrottlingExceptionis modified to catch the error correctly.PR Checklist