Update definitions.json redelivered-> delivered #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbozhenko
commented
Jan 13, 2025
| @@ -725,7 +725,7 @@ | |||
| }, | |||
| "max_deliver": { | |||
| "$ref": "#/definitions/golang_int", | |||
| "description": "The number of times a message will be redelivered to consumers if not acknowledged in time", | |||
| "description": "The number of times a message will be delivered to consumers if not acknowledged in time", | |||
There was a problem hiding this comment.
@ripienaar
Or should it include the full, more complete, paragraph from the docs?
https://docs.nats.io/nats-concepts/jetstream/consumers#general
The maximum number of times a specific message delivery will be attempted. Applies to any message that is re-sent due to acknowledgment policy (i.e., due to a negative acknowledgment or no acknowledgment sent by the client). The default is -1 (redeliver until acknowledged). Messages that have reached the maximum delivery count will stay in the stream.
There was a problem hiding this comment.
Yeah redelivered is the wrong term, we should rewrite the cases where max_deliver is stated in these terms to be clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to nats-io/nats.js#186
It was added in nats-io/nats-server@89ff13a#diff-172561e6cce90cfe99be04c3a0381c1c019b97b809a429d87e60934e96f06139R823
And I did confirm that the number is compared to delivery count:
https://github.com/nats-io/nats-server/blob/5137ad891865be498a8f2ef42426033bd09c82d7/server/consumer.go#L4009