Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definitions.json redelivered-> delivered #610

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update definitions.json redelivered-> delivered #610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion schema_source/jetstream/api/v1/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@
},
"max_deliver": {
"$ref": "#/definitions/golang_int",
"description": "The number of times a message will be redelivered to consumers if not acknowledged in time",
"description": "The number of times a message will be delivered to consumers if not acknowledged in time",
Copy link
Contributor Author

@alexbozhenko alexbozhenko Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ripienaar
Or should it include the full, more complete, paragraph from the docs?
https://docs.nats.io/nats-concepts/jetstream/consumers#general

The maximum number of times a specific message delivery will be attempted. Applies to any message that is re-sent due to acknowledgment policy (i.e., due to a negative acknowledgment or no acknowledgment sent by the client). The default is -1 (redeliver until acknowledged). Messages that have reached the maximum delivery count will stay in the stream.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah redelivered is the wrong term, we should rewrite the cases where max_deliver is stated in these terms to be clearer

"default": -1
},
"filter_subject": {
Expand Down
Loading