Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jlab menu customization #2259

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Conversation

marcelovilla
Copy link
Member

Reference Issues or PRs

See #2216

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): UI changes

This PR implements the following changes in the JupyterLab menu configuration:

  1. Remove Log out and Hub Control Panel items from the File menu and add a Home item instead.
  2. Rename Nebari menu item to Services and put it before (left) of Help.
  3. Add link to Nebari docs in the Help menu.

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was moving Home to the front of File intended, or was it meant to remain in the Services submenu and be just disabled in the File menu? It is not clear to me from #2216 (comment).

Looks good otherwise:

Screenshot from 2024-02-19 11-42-56

image

image

@marcelovilla
Copy link
Member Author

@krassowski yes, it was meant to be moved from the Services menu to the top of the File menu. The issue was not very clear about that but we discussed it internally.

…etes/services/jupyterhub/files/jupyterlab/overrides.json

Co-authored-by: Michał Krassowski <[email protected]>
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marcelovilla marcelovilla merged commit 195738e into develop Feb 19, 2024
27 checks passed
@marcelovilla marcelovilla deleted the feature/jlab-menu-customization branch February 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants