-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jlab menu customization #2259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was moving Home
to the front of File
intended, or was it meant to remain in the Services
submenu and be just disabled in the File
menu? It is not clear to me from #2216 (comment).
Looks good otherwise:
...tes_services/template/modules/kubernetes/services/jupyterhub/files/jupyterlab/overrides.json
Outdated
Show resolved
Hide resolved
@krassowski yes, it was meant to be moved from the Services menu to the top of the File menu. The issue was not very clear about that but we discussed it internally. |
…etes/services/jupyterhub/files/jupyterlab/overrides.json Co-authored-by: Michał Krassowski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reference Issues or PRs
See #2216
What does this implement/fix?
Put a
x
in the boxes that applyThis PR implements the following changes in the JupyterLab menu configuration:
Testing
Any other comments?