Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/jlab menu customization #2259

Merged
merged 7 commits into from
Feb 19, 2024
Merged

Feature/jlab menu customization #2259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f6035e6
Rename Nebari menu item label and move it before the Help menu item.
marcelovilla Feb 16, 2024
0f34ffd
Add Nebari documentation as an item in the Help menu.
marcelovilla Feb 16, 2024
2ef0863
Disable Hub Control Panel and Log out items and add Home item in the…
marcelovilla Feb 16, 2024
e8b91a1
Move Home item to the top.
marcelovilla Feb 16, 2024
cb9e1ac
Make sure that the Services menu item is left from the Help menu.
marcelovilla Feb 16, 2024
790e7af
Update menu item to Home because it changed in the UI.
marcelovilla Feb 18, 2024
d11993e
Update src/_nebari/stages/kubernetes_services/template/modules/kubern…
marcelovilla Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 45 additions & 5 deletions ..._services/template/modules/kubernetes/services/jupyterhub/files/jupyterlab/overrides.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,40 @@
"@jupyterlab/mainmenu-extension:plugin": {
"menus": [
{
"id": "jp-mainmenu-nebari",
"disabled": false,
"label": "Nebari",
"rank": 1001,
"id": "jp-mainmenu-file",
"items": [
{
"command": "help:open",
"rank": 0,
"args": {
"url": "/hub/home",
"text": "Home",
"newBrowserTab": true
}
},
{
"type": "submenu",
"submenu": {
"id": "jp-mainmenu-file-new"
},
"rank": 0.5
},
{
"command": "hub:control-panel",
"rank": 0
"disabled": true
},
{
"command": "hub:logout",
"disabled": true
}
]
},
{
"id": "jp-mainmenu-services",
"disabled": false,
"label": "Services",
"rank": 1000,
"items": [
{
"command": "help:open",
"rank": 1,
Expand Down Expand Up @@ -61,6 +86,21 @@
}
}
]
},
{
"id": "jp-mainmenu-help",
"rank": 1001,
"items": [
{
"command": "help:open",
"rank": 1001,
"args": {
"url": "https://www.nebari.dev/docs/welcome/",
"text": "Nebari documentation",
"newBrowserTab": true
}
}
]
}
]
}
Expand Down
4 changes: 1 addition & 3 deletions tests/common/navigator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,9 +413,7 @@ def stop_server(self) -> None:
self.page.get_by_text("File", exact=True).click()

with self.context.expect_page() as page_info:
self.page.get_by_role(
"menuitem", name="Hub Control Panel", exact=True
).click()
self.page.get_by_role("menuitem", name="Home", exact=True).click()

home_page = page_info.value
home_page.wait_for_load_state()
Expand Down
Loading