Prepare 2024.3.1rc1 release #2275
Conversation
| @@ -12,8 +12,8 @@ | |||
| DEFAULT_GKE_RELEASE_CHANNEL = "UNSPECIFIED" | |||
|
|
|||
| DEFAULT_NEBARI_DASK_VERSION = CURRENT_RELEASE | |||
| DEFAULT_NEBARI_IMAGE_TAG = CURRENT_RELEASE | |||
| DEFAULT_NEBARI_WORKFLOW_CONTROLLER_IMAGE_TAG = "2024.1.1" | |||
| DEFAULT_NEBARI_IMAGE_TAG = "2024.2.1rc2" | |||
There was a problem hiding this comment.
@dcmcand In #2227 you did not have any changes for DEFAULT_NEBARI_IMAGE_TAG but I am assuming we do want to point to the latest RC in https://github.com/nebari-dev/nebari-docker-images, right? Otherwise we would be testing against older versions of the images.
There was a problem hiding this comment.
I specified them in the nebari-config.yaml rather than here. Bu this should be fine as long as we change it back to CURRENT_RELEASE before the release
| @@ -12,8 +12,8 @@ | |||
| DEFAULT_GKE_RELEASE_CHANNEL = "UNSPECIFIED" | |||
|
|
|||
| DEFAULT_NEBARI_DASK_VERSION = CURRENT_RELEASE | |||
| DEFAULT_NEBARI_IMAGE_TAG = CURRENT_RELEASE | |||
| DEFAULT_NEBARI_WORKFLOW_CONTROLLER_IMAGE_TAG = "2024.1.1" | |||
| DEFAULT_NEBARI_IMAGE_TAG = "2024.2.1rc2" | |||
There was a problem hiding this comment.
I specified them in the nebari-config.yaml rather than here. Bu this should be fine as long as we change it back to CURRENT_RELEASE before the release
src/_nebari/upgrade.py
Outdated
| ): | ||
| rich.print("\n ⚠️ Warning ⚠️") | ||
| rich.print( | ||
| "-> Please run the [green]rm -rf stages[/green] so that we can regenerate an updated set of Terraform scripts for your deployment." |
There was a problem hiding this comment.
This can cause trouble for people using local tf state. See #2271. I think just runnning nebari render should do the same thing here. Can we verify this is actually needed?
There was a problem hiding this comment.
At a minimum I think we should change this to mv stages stages.old or something similar. This messed me up recently. Luckily I was able to get stages back by trash-cli
There was a problem hiding this comment.
For some context, this rm -rf was needed in the past when we deleted some files in stages due to deprecation (clearml.tf, prefect.tf, kbatch.tf). This was needed b/c running nebari render wouldn't overwrite/delete the files that were no longer part of nebari, but the rm -rf did work (assuming non local state).
|
@Adam-D-Lewis and @dcmcand thank you for the comments. I want us to discuss better ways to handle upgrades in the future, but for this release I have followed your advice and just added a message to backup the original rendered files. |
src/_nebari/upgrade.py
Outdated
| ): | ||
| rich.print("\n ⚠️ Warning ⚠️") | ||
| rich.print( | ||
| "-> Please run [green]mv stages stages.old[/green] so that we can keep a backup of the original Terraform scripts and regenerate an updated set of them for your deployment." |
There was a problem hiding this comment.
Take this comment or leave it, but I don't feel like even this is necessary for this release. I feel like this could be as simple as printing "upgrading to 2024.2.1" or something like that. I am still approving in case you decide to keep this, but I don't think we need it.
There was a problem hiding this comment.
It's probably not because we're not deprecating anything. I took your suggestion and incorporated it.
…ri-dev/nebari into prepare-2024.2.1rc1-release
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Any other comments?
We still have some blockers for the next release but I want to update the docker image tags in
developso people can deploy from there to test.