Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2024.3.1rc1 release #2275

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Prepare 2024.3.1rc1 release #2275

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
529adc1
Change nebari and nebari workflow controller image tags.
marcelovilla Feb 22, 2024
a1e5fd1
Add upgrade message for new version.
marcelovilla Feb 22, 2024
3bd47cb
Update version and warning message.
marcelovilla Mar 5, 2024
228810e
Merge branch 'develop' into prepare-2024.2.1rc1-release
marcelovilla Mar 5, 2024
2abed56
Update upgrade message.
marcelovilla Mar 5, 2024
02e63d5
Merge branch 'prepare-2024.2.1rc1-release' of https://github.com/neba…
marcelovilla Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/_nebari/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
DEFAULT_GKE_RELEASE_CHANNEL = "UNSPECIFIED"

DEFAULT_NEBARI_DASK_VERSION = CURRENT_RELEASE
DEFAULT_NEBARI_IMAGE_TAG = CURRENT_RELEASE
DEFAULT_NEBARI_WORKFLOW_CONTROLLER_IMAGE_TAG = "2024.1.1"
DEFAULT_NEBARI_IMAGE_TAG = "2024.2.1rc2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcmcand In #2227 you did not have any changes for DEFAULT_NEBARI_IMAGE_TAG but I am assuming we do want to point to the latest RC in https://github.com/nebari-dev/nebari-docker-images, right? Otherwise we would be testing against older versions of the images.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I specified them in the nebari-config.yaml rather than here. Bu this should be fine as long as we change it back to CURRENT_RELEASE before the release

DEFAULT_NEBARI_WORKFLOW_CONTROLLER_IMAGE_TAG = "2024.2.1rc2"

DEFAULT_CONDA_STORE_IMAGE_TAG = "2024.1.1"

Expand Down
14 changes: 14 additions & 0 deletions src/_nebari/upgrade.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,20 @@ def _version_specific_upgrade(
return config


class Upgrade_2024_2_1(UpgradeStep):
version = "2024.2.1"

def _version_specific_upgrade(
self, config, start_version, config_filename: Path, *args, **kwargs
):
rich.print("\n ⚠️ Warning ⚠️")
rich.print(
"-> Please run the [green]rm -rf stages[/green] so that we can regenerate an updated set of Terraform scripts for your deployment."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can cause trouble for people using local tf state. See #2271. I think just runnning nebari render should do the same thing here. Can we verify this is actually needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a minimum I think we should change this to mv stages stages.old or something similar. This messed me up recently. Luckily I was able to get stages back by trash-cli

Copy link
Member

@Adam-D-Lewis Adam-D-Lewis Feb 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some context, this rm -rf was needed in the past when we deleted some files in stages due to deprecation (clearml.tf, prefect.tf, kbatch.tf). This was needed b/c running nebari render wouldn't overwrite/delete the files that were no longer part of nebari, but the rm -rf did work (assuming non local state).

)

return config


__rounded_version__ = str(rounded_ver_parse(__version__))

# Manually-added upgrade steps must go above this line
Expand Down
Loading