-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Leveldb RocksDb Runtime Binaries #3665
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, we discussed that in a meeting.
I am not in agreement yet.
I am with this pr, when NGD release the cli, it uses ngd-leveldb, so it should be considered a valid way of getting leveldb by downloading it from NGD. |
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" /> | ||
<PackageReference Include="System.CommandLine.NamingConventionBinder" Version="2.0.0-beta4.22272.1" /> | ||
</ItemGroup> | ||
|
||
<Target Name="MoveLevelDbForBuild" BeforeTargets="PostBuildEvent"> | ||
<Move SourceFiles="$(OutputPath)/LevelDBStore.dll" DestinationFolder="$(OutDir)/Plugins/LevelDBStore" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just this part is good for now, @cschuchardt88 .
If so we close the other PR I opened.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to open this separately, because the rest of the PR, for now, I am not in agreement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you specify what you do not like with this PR? So maybe we can work on fixing it or answering any concerns or reasons you have.
We even have |
Description
Deploys the runtime binaries for
neo-cli
. So developer don't have to copy the plugins and its deps.Enabled leveldb to run tests on all OSS.
Type of change
How Has This Been Tested?
Checklist: