Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Leveldb RocksDb Runtime Binaries #3665

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

cschuchardt88
Copy link
Member

@cschuchardt88 cschuchardt88 commented Jan 9, 2025

Description

Deploys the runtime binaries for neo-cli. So developer don't have to copy the plugins and its deps.

Enabled leveldb to run tests on all OSS.

  • Local Development
  • Github Release
  • Github workflow tests for all OS, windows, linux, macos
  • github docker release
  • dev containers
  • dotnet publish, build

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Locally
  • My Github Repo

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, we discussed that in a meeting.
I am not in agreement yet.

@Jim8y
Copy link
Contributor

Jim8y commented Jan 9, 2025

I am with this pr, when NGD release the cli, it uses ngd-leveldb, so it should be considered a valid way of getting leveldb by downloading it from NGD.

</ItemGroup>

<ItemGroup>
<PackageReference Include="System.CommandLine" Version="2.0.0-beta4.22272.1" />
<PackageReference Include="System.CommandLine.NamingConventionBinder" Version="2.0.0-beta4.22272.1" />
</ItemGroup>

<Target Name="MoveLevelDbForBuild" BeforeTargets="PostBuildEvent">
<Move SourceFiles="$(OutputPath)/LevelDBStore.dll" DestinationFolder="$(OutDir)/Plugins/LevelDBStore" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just this part is good for now, @cschuchardt88 .
If so we close the other PR I opened.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to open this separately, because the rest of the PR, for now, I am not in agreement.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Jan 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you specify what you do not like with this PR? So maybe we can work on fixing it or answering any concerns or reasons you have.

@cschuchardt88
Copy link
Member Author

cschuchardt88 commented Jan 11, 2025

I am with this pr, when NGD release the cli, it uses ngd-leveldb, so it should be considered a valid way of getting leveldb by downloading it from NGD.

We even have neo-cli send the end user to NGD github page to download leveldb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants