Disables flaky debouncing test #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
daveajrussell
approved these changes
Dec 23, 2024
| @@ -27,7 +27,8 @@ test.fail( | |||
| }, | |||
| ); | |||
|
|
|||
| test('onExecute updates should override debounce updates', async ({ | |||
| // TODO Fix this test | |||
| test.skip('onExecute updates should override debounce updates', async ({ | |||
There was a problem hiding this comment.
I think we can use test.fixme which I reckon signals the intent to fix better than test.skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've carded this as one of the paper cuts we should address in Q1.
Why
After a serious of PRs trying to address debouncing problems, the functionality seems to still be flaky somehow
https://github.com/neo4j/cypher-language-support/pulls?q=is%3Apr+author%3Adanieladugyan+is%3Aclosed