Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables flaky debouncing test #313

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Disables flaky debouncing test #313

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2028ff2
Disables flaky debouncing test
ncordon Dec 18, 2024
ef58789
Uses fixme for the test
ncordon Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/react-codemirror/src/e2e_tests/debounce.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@ test.fail(
},
);

test('onExecute updates should override debounce updates', async ({
// TODO Fix this test
test.skip('onExecute updates should override debounce updates', async ({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use test.fixme which I reckon signals the intent to fix better than test.skip

mount,
page,
}) => {
Expand Down
Loading