Move infrastructure helpers to package #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertandrejev
force-pushed
the
feat/extract-helpers-neutronjs
branch
from
196a207
to
d14679e
Compare
swelf19
previously approved these changes
Aug 10, 2023
albertandrejev
force-pushed
the
feat/extract-helpers-neutronjs
branch
from
201228e
to
583e44e
Compare
NeverHappened
previously approved these changes
Aug 10, 2023
| neutronChain, | ||
| daoCoreAddress, | ||
| ); | ||
| daoParent = new dao.Dao(neutronChain, daoContracts); |
There was a problem hiding this comment.
maybe mainDao like below?
sotnikov-s
reviewed
Aug 14, 2023
albertandrejev
dismissed stale reviews from NeverHappened and swelf19
via
96b476d
sotnikov-s
previously approved these changes
Aug 17, 2023
albertandrejev
force-pushed
the
feat/extract-helpers-neutronjs
branch
from
c8a4e09
to
e285396
Compare
pr0n00gler
approved these changes
Sep 11, 2023
sotnikov-s
reviewed
Sep 12, 2023
| @@ -39,6 +39,7 @@ | |||
| "@cosmos-client/core": "0.45.13", | |||
| "@cosmos-client/cosmwasm": "^0.20.1", | |||
| "@cosmos-client/ibc": "^1.2.1", | |||
| "@neutron-org/neutronjsplus": "^0.0.9", | |||
There was a problem hiding this comment.
the latest version is 0.0.8, isn't it? https://github.com/neutron-org/neutronjsplus/blob/e2b4bf6482a0377b996ae8de0f66af62b5a89c6c/package.json#L3
There was a problem hiding this comment.
you are right, I forgot to push changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.