Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move infrastructure helpers to package #185

Merged
merged 20 commits into from
Sep 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ NO_DOCKER=1 yarn test # all tests
...
```

## Development

If you're developing integration tests and need to add additional helper methods to the @neutron-org/neutronjs packages, start by cloning the package repository. Use the command git clone [email protected]:neutron-org/neutronjs.git. After cloning, you have two options: either alter the package reference in the package.json file to point to your cloned repository, or use yarn link.

Once the JavaScript helper code in your local repository is ready, your next step is to create a Pull Request (PR). This PR must be reviewed and approved before it can be merged into the main branch.

However, even after the merge, you cannot immediately use the new package version in your integration tests. First, you need to wait until the updated version of the package will be published to the npmjs repository. After the new version has been published, you can incorporate it into your integration tests. This will allow you to complete the testing sequence in your GitHub Actions workflow.

## Warning

Since docker-compose doesn't rebuild images on file changing, there is a chance for one to launch the tests with an
Expand Down
59 changes: 0 additions & 59 deletions gen-proto-ibc-go.sh

This file was deleted.

42 changes: 0 additions & 42 deletions gen-proto.sh

This file was deleted.

4 changes: 2 additions & 2 deletions globalSetup.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { setup } from './src/helpers/env';
import { env } from '@neutron-org/neutronjsplus';

export default async () => {
const host1 = process.env.NODE1_URL || 'http://localhost:1317';
const host2 = process.env.NODE2_URL || 'http://localhost:1316';
!process.env.NO_DOCKER && (await setup(host1, host2));
!process.env.NO_DOCKER && (await env.setup(host1, host2));
};
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"@cosmos-client/core": "0.45.13",
"@cosmos-client/cosmwasm": "^0.20.1",
"@cosmos-client/ibc": "^1.2.1",
"@neutron-org/neutronjsplus": "^0.0.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right, I forgot to push changes

"@types/lodash": "^4.14.182",
"@types/long": "^4.0.2",
"axios": "^0.27.2",
Expand Down
Loading