-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move infrastructure helpers to package #185
Merged
+1,473
−328,399
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
e13e047
user helpers from neutronjs package
albertandrejev faf46b4
Update dao tests
albertandrejev b247e58
Move part of the tests to new helpers repo
albertandrejev 67172ae
Update tests
albertandrejev edf93f2
fixes
albertandrejev 728d58c
Update test with new package
albertandrejev f55cfa8
fix wrong call
albertandrejev b18a656
Remove not used code
albertandrejev 042616e
Change development flow
albertandrejev 761ec30
change neutronjs to neutronjsplus package name
albertandrejev 93c2d4f
fix helpers usage
albertandrejev bcad27d
fix tests
albertandrejev e1dc85d
fix lint errors
albertandrejev db69b56
upgrade neutronjsplus version
albertandrejev 17d590b
Add missed import
albertandrejev 393ab17
Fix import
albertandrejev 599df0e
Fix import
albertandrejev 630c795
Fix imports
albertandrejev 98a761c
and another one import fix
albertandrejev e285396
Fix code after rebase
albertandrejev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,14 @@ NO_DOCKER=1 yarn test # all tests | |
... | ||
``` | ||
|
||
## Development | ||
|
||
If you're developing integration tests and need to add additional helper methods to the @neutron-org/neutronjs packages, start by cloning the package repository. Use the command git clone [email protected]:neutron-org/neutronjs.git. After cloning, you have two options: either alter the package reference in the package.json file to point to your cloned repository, or use yarn link. | ||
|
||
Once the JavaScript helper code in your local repository is ready, your next step is to create a Pull Request (PR). This PR must be reviewed and approved before it can be merged into the main branch. | ||
|
||
However, even after the merge, you cannot immediately use the new package version in your integration tests. First, you need to wait until the updated version of the package will be published to the npmjs repository. After the new version has been published, you can incorporate it into your integration tests. This will allow you to complete the testing sequence in your GitHub Actions workflow. | ||
|
||
## Warning | ||
|
||
Since docker-compose doesn't rebuild images on file changing, there is a chance for one to launch the tests with an | ||
|
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
import { setup } from './src/helpers/env'; | ||
import { env } from '@neutron-org/neutronjsplus'; | ||
|
||
export default async () => { | ||
const host1 = process.env.NODE1_URL || 'http://localhost:1317'; | ||
const host2 = process.env.NODE2_URL || 'http://localhost:1316'; | ||
!process.env.NO_DOCKER && (await setup(host1, host2)); | ||
!process.env.NO_DOCKER && (await env.setup(host1, host2)); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the latest version is 0.0.8, isn't it? https://github.com/neutron-org/neutronjsplus/blob/e2b4bf6482a0377b996ae8de0f66af62b5a89c6c/package.json#L3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, I forgot to push changes