Feat: missing tokenfactory bindings #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 2, 2024
swelf19
reviewed
Feb 7, 2024
swelf19
reviewed
Feb 7, 2024
swelf19
reviewed
Feb 8, 2024
| suite.Nil(events) | ||
| suite.Equal(uint64(1), response.SequenceId) | ||
| suite.Equal("channel-2", response.Channel) | ||
| // huh? |
There was a problem hiding this comment.
as far as i understand, the reflect contract does not let through response from a binding handler. If binding returns non empty result we should be able to test it somehow. But i'm not insist
There was a problem hiding this comment.
Yeah, i left these comments to not forget to think about that. And i found a solution - now reflect contract returns response of message execution thus it's visible to the test
swelf19
reviewed
Feb 8, 2024
| @@ -5,6 +5,9 @@ import ( | |||
| "fmt" | |||
| "testing" | |||
|
|
|||
| types2 "github.com/CosmWasm/wasmd/x/wasm/types" | |||
There was a problem hiding this comment.
rename alias to something meaningful?
NeverHappened
previously approved these changes
Feb 9, 2024
* add unit tests for tokenfactory ForceTransfer method
NeverHappened
previously approved these changes
Feb 10, 2024
NeverHappened
previously approved these changes
Feb 12, 2024
NeverHappened
approved these changes
Feb 12, 2024
swelf19
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing
ForceTransferandSetDenomMetadatamessages for the TokenFactory moduleRelated PRs: