Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: missing tokenfactory bindings #431

Merged
merged 8 commits into from
Feb 13, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
115 changes: 81 additions & 34 deletions x/tokenfactory/client/cli/tx.go
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
package cli

import (
"encoding/json"
"fmt"
"os"

banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
"github.com/spf13/cobra"

"github.com/cosmos/cosmos-sdk/client"
Expand All @@ -28,9 +31,10 @@ func GetTxCmd() *cobra.Command {
NewCreateDenomCmd(),
NewMintCmd(),
NewBurnCmd(),
// NewForceTransferCmd(),
NewForceTransferCmd(),
NewChangeAdminCmd(),
NewSetBeforeSendHook(),
NewSetDenomMetadataCmd(),
)

return cmd
Expand Down Expand Up @@ -136,39 +140,82 @@ func NewBurnCmd() *cobra.Command {
return cmd
}

// // NewForceTransferCmd broadcast MsgForceTransfer
// func NewForceTransferCmd() *cobra.Command {
// cmd := &cobra.Command{
// Use: "force-transfer [amount] [transfer-from-address] [transfer-to-address] [flags]",
// Short: "Force transfer tokens from one address to another address. Must have admin authority to do so.",
// Args: cobra.ExactArgs(3),
// RunE: func(cmd *cobra.Command, args []string) error {
// clientCtx, err := client.GetClientTxContext(cmd)
// if err != nil {
// return err
// }

// txf := tx.NewFactoryCLI(clientCtx, cmd.Flags()).WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever)

// amount, err := sdk.ParseCoinNormalized(args[0])
// if err != nil {
// return err
// }

// msg := types.NewMsgForceTransfer(
// clientCtx.GetFromAddress().String(),
// amount,
// args[1],
// args[2],
// )

// return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf, msg)
// },
// }

// flags.AddTxFlagsToCmd(cmd)
// return cmd
// }
// NewForceTransferCmd broadcast MsgForceTransfer
func NewForceTransferCmd() *cobra.Command {
cmd := &cobra.Command{
Use: "force-transfer [amount] [transfer-from-address] [transfer-to-address] [flags]",
Short: "Force transfer tokens from one address to another address. Must have admin authority to do so.",
Args: cobra.ExactArgs(3),
RunE: func(cmd *cobra.Command, args []string) error {
clientCtx, err := client.GetClientTxContext(cmd)
if err != nil {
return err
}

txf, err := tx.NewFactoryCLI(clientCtx, cmd.Flags())
if err != nil {
return err
}

amount, err := sdk.ParseCoinNormalized(args[0])
if err != nil {
return err
}

msg := types.NewMsgForceTransfer(
clientCtx.GetFromAddress().String(),
amount,
args[1],
args[2],
)

return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf.WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever), msg)
},
}

flags.AddTxFlagsToCmd(cmd)
return cmd
}

// NewSetDenomMetadataCmd broadcast MsgSetDenomMetadata msg
func NewSetDenomMetadataCmd() *cobra.Command {
cmd := &cobra.Command{
Use: "set-denom-metadata [metadata-file] [flags]",
Short: "Sets a bank metadata for a token denom. Must have admin authority to do so.",
Args: cobra.ExactArgs(1),
RunE: func(cmd *cobra.Command, args []string) error {
clientCtx, err := client.GetClientTxContext(cmd)
if err != nil {
return err
}

txf, err := tx.NewFactoryCLI(clientCtx, cmd.Flags())
if err != nil {
return err
}

metadataBytes, err := os.ReadFile(args[1])
if err != nil {
return err
}

var metadata banktypes.Metadata
if err = json.Unmarshal(metadataBytes, &metadata); err != nil {
return err
}

msg := types.NewMsgSetDenomMetadata(
clientCtx.GetFromAddress().String(),
metadata,
)

return tx.GenerateOrBroadcastTxWithFactory(clientCtx, txf.WithTxConfig(clientCtx.TxConfig).WithAccountRetriever(clientCtx.AccountRetriever), msg)
},
}

flags.AddTxFlagsToCmd(cmd)
return cmd
}

// NewChangeAdminCmd broadcast MsgChangeAdmin
func NewChangeAdminCmd() *cobra.Command {
Expand Down
2 changes: 1 addition & 1 deletion x/tokenfactory/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func (m MsgChangeAdmin) GetSigners() []sdk.AccAddress {

var _ sdk.Msg = &MsgSetDenomMetadata{}

// NewMsgChangeAdmin creates a message to burn tokens
// NewMsgSetDenomMetadata creates a message to create metadata for a denom
NeverHappened marked this conversation as resolved.
Show resolved Hide resolved
func NewMsgSetDenomMetadata(sender string, metadata banktypes.Metadata) *MsgSetDenomMetadata {
return &MsgSetDenomMetadata{
Sender: sender,
Expand Down
Loading