-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove component update script #3464
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
nf_core/components/components_utils.py:218
- [nitpick] Using 'type' as a parameter name shadows the built-in function 'type'. Consider renaming it to a more descriptive name such as 'data_type' or 'channel_type'.
def _iterate_input_output(type) -> DictWithStrAndTuple:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not working because now we have jinja template strings in the modules.json
file, so it can't be parsed when we update the modules.
One option would be to
- create a pipeline form the template
- update the modules
- copy the updated modules to the template folder
- update sha values in modules.json (this can't be done by parsing the
modules.json
for the same reason)
But I think the best would be to give up and do it manually
okay, removed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
script removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
force merging this, because we don't trigger pytests for these kind of changes. |
Let's give it one more shot