Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component update script #3464

Merged
merged 3 commits into from
Mar 3, 2025

Conversation

mashehu
Copy link
Contributor

@mashehu mashehu commented Feb 24, 2025

Let's give it one more shot

@mashehu mashehu changed the base branch from main to dev February 24, 2025 12:58
@nf-core nf-core deleted a comment from github-actions bot Feb 24, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 51 out of 51 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

nf_core/components/components_utils.py:218

  • [nitpick] Using 'type' as a parameter name shadows the built-in function 'type'. Consider renaming it to a more descriptive name such as 'data_type' or 'channel_type'.
def _iterate_input_output(type) -> DictWithStrAndTuple:

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.50%. Comparing base (0a75afa) to head (a525ce9).

Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not working because now we have jinja template strings in the modules.json file, so it can't be parsed when we update the modules.
One option would be to

  1. create a pipeline form the template
  2. update the modules
  3. copy the updated modules to the template folder
  4. update sha values in modules.json (this can't be done by parsing the modules.json for the same reason)

But I think the best would be to give up and do it manually

@mashehu mashehu changed the title Fix component update script Remove component update script Feb 24, 2025
@mashehu
Copy link
Contributor Author

mashehu commented Feb 24, 2025

okay, removed it.
@nf-core-bot changelog

Copy link

@ningyuxin1999 ningyuxin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

script removed

@mashehu mashehu dismissed mirpedrol’s stale review March 3, 2025 10:24

script is now removed

@mashehu mashehu enabled auto-merge March 3, 2025 10:24
Copy link

@ningyuxin1999 ningyuxin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@mashehu
Copy link
Contributor Author

mashehu commented Mar 3, 2025

force merging this, because we don't trigger pytests for these kind of changes.

@mashehu mashehu disabled auto-merge March 3, 2025 10:45
@mashehu mashehu merged commit fce807d into nf-core:dev Mar 3, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants