Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reworked #202] Add simple git functions to test contract behaviour #203

Closed
wants to merge 58 commits into from
Closed

[Reworked #202] Add simple git functions to test contract behaviour #203

wants to merge 58 commits into from

Conversation

HLWeil
Copy link
Member

@HLWeil HLWeil commented Sep 21, 2023

(Last rebase caused bigger issues in initial branch)

kMutagene and others added 30 commits September 12, 2023 10:16
@kMutagene
fix #182
8b5093d 
- rename FileSystemTree.filter -> FileSystemTree.filterFiles
- add FileSystemTree.filter that also applies predicate to folder names
- add tests that show difference when filtering for names starting with '.'
@HLWeil
Merge pull request #186 from nfdi4plants/fix-#182
d6c525e 
fix #182
@kMutagene
implement #188
35c3577 
- Add FileSystemTree.FilterFolders
- FileSystemTree.FilterFiles now only filters files (returns empty folders instead of removing them)
- fix some static member bindings
- Add tests for FilterFolders
- Tests now test both instance and static methods
@kMutagene
implement #187
095114d 
-Add `GetRegisteredPayload` and `GetAdditionalPayload`

- Add tests
@kMutagene
fix GetRegisteredPayload cell conversion failure
907f3a2 
- iterate through all tables instead of the first only
- use ToFreeTextCell(), which is a proper conversion instead of AsFreeTextCell which is a match that can fail
@kMutagene
Use path literals for payload path filtering
affab06
@HLWeil
Merge pull request #189 from nfdi4plants/implement-#187
4e676ea 
FileSystemTree additions and Payload detection
@Freymaurer @HLWeil
Update ArcTypes to ref parent 🚧
03e9784
@Freymaurer @HLWeil
Work on update 🚧
2912c02
@Freymaurer @HLWeil
isa and isa.json tests pass ✔️
658f914
@Freymaurer @HLWeil
Add ArcStudy assay handling tests ✅
bb2a84c
@Freymaurer @HLWeil
Add more tests ✅
923eb2d
@HLWeil
add registered studies to investigation
a155528
@Freymaurer @HLWeil
Rename study.assay api and fix tests
de7f51f
@HLWeil
fix and improve ISA Spreadsheet tests for assay/study registration
535eaff
@HLWeil
start adding update functions
72e1b02
@Freymaurer @HLWeil
Work on UpdateBy on assay,study,investigation 🚧
145dbb7
@HLWeil
finish up first version of updated arc read in
ed7be2e
@HLWeil
add helper functions
47489d1
@HLWeil
add table updating tests and fix underlying functions
bf7b5ca
@HLWeil
fix spreadsheet reader parsing empty ontology annotations
317be82
@HLWeil
test and fix arc read in with updating of objects against each other
ef0ec6b
@HLWeil
some comments and small adjustments
03f1dd2
@HLWeil
fix merge inconsistencies
f812f4c
@HLWeil
Merge pull request #184 from nfdi4plants/developer_TopLevelAssays
b18400f 
ArcInvestigation level assays
@Freymaurer
Add ARCtrl tests to runTests target 🐛
f3cb081
@Freymaurer
Add SemVer logic ✅
ec3f7d0
@Freymaurer
Add templates+json+tests ✨✅
8c9e1db
@Freymaurer
Apply changes according to PR-review #191
e5353b0
@Freymaurer
Change json-format to write ProcessSequence instead of ArcTable
a806c7d
Freymaurer and others added 28 commits September 19, 2023 12:52
@Freymaurer
Add js arctrl tests to CI
62b27d9
@Freymaurer
Make tests pass
a67d9e2
@HLWeil
fix protocol REF appearing after ArcTable to process roundabout conve…
9764151 
…rsion
@Freymaurer
Add template equality + tests
b65d2dc
@Freymaurer
Improve robustness of runTests logic ✨
22f1b92
@Freymaurer
Update StructuralEquals naming
6c5bff8
@Freymaurer
Merge pull request #191 from nfdi4plants/developer_TemplatesJson
b46e9a4 
Developer templates json
@HLWeil
fix and test metadatasheet reader interpreting empty strings
2a81a65
@HLWeil
fix and test table updating failing for specific tables
ae9ff1c
@Freymaurer
Merge pull request #192 from nfdi4plants/fixes
104282e 
Fixes
@HLWeil
restructure testing environment
91b3f01
@HLWeil
unified mocha and expecto functionality into TestingUtils project
70f288b
@Freymaurer
Merge pull request #194 from nfdi4plants/developer_testRestructure
2ede92d 
Restructure testing environment
@HLWeil
bump to 1.0.0-alpha5
110b19d
@HLWeil
add test and fix for empty ArcTable process conversion
e32c196 
#193
@Freymaurer
Merge pull request #199 from nfdi4plants/developer_templates
25e71b7 
Developer templates
@Freymaurer
Improve UpdateHeader forceConvert flag 🐛#198
1c395d0
@HLWeil
cleanup unnecessary testfiles
f37c0a4
@HLWeil
add template xlsx parsing
0c9980f
@Freymaurer
Work on #197 🚧
d24e96a
@Freymaurer
Add GetContent() for CompositeCell #190
e8854d4
@Freymaurer
Add tests for CompositeCell.GetContent ✅
24b415a
@Freymaurer
Add CompositeHeader js helpers #197
476dc6d
@Freymaurer
Add native js test ✅
a14f180
@Freymaurer
Merge pull request #200 from nfdi4plants/developer_Issues
2f4709e 
Solve Issues
@HLWeil
test and fix template spreadsheet parsing
0b20e1c
@HLWeil
add and fix full template xlsx file parsing
2419fa5
@HLWeil
Merge pull request #201 from nfdi4plants/developer_templates
437c17f 
Template spreadsheet parsers
@HLWeil
Copy link
Member Author

HLWeil commented Sep 21, 2023

Wrong branch...

@HLWeil HLWeil closed this Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HLWeil @kMutagene @Freymaurer