Bump mlir-air to 3d1a4e19ff748897a37e0eb88b59999197dbc0f8 #868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzhang93
reviewed
Nov 1, 2024
build_tools/ci/cpu_comparison/run.py
Outdated
Comment on lines
540
to
541
| tile_pipeline="pad-pack", | ||
| lower_to_aie_pipeline="air", |
There was a problem hiding this comment.
Can you leave the default as "pack-peel" and "objectFifo"? You can add a test for pad-pack pipeline if you like, but I think the current tests are enough.
This reverts commit f04fe91.
yzhang93
approved these changes
Nov 1, 2024
yzhang93
reviewed
Nov 1, 2024
build_tools/ci/run_matmul_test.sh
Outdated
| @@ -556,16 +556,16 @@ run_matmul_test \ | |||
| ################################################################### | |||
|
|
|||
| # TODO: re-enable after fixing in AIR | |||
There was a problem hiding this comment.
Nit: You can delete this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.