Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump mlir-air to 3d1a4e19ff748897a37e0eb88b59999197dbc0f8 #868

Merged
merged 5 commits into from
Nov 1, 2024
Merged

Bump mlir-air to 3d1a4e19ff748897a37e0eb88b59999197dbc0f8 #868

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
16495d9
Bump mlir-air
erwei-xilinx Nov 1, 2024
2e325be
Re-enable air pipeline for matmul tests
erwei-xilinx Nov 1, 2024
f04fe91
Re-enable air pipeline for cpu comparison tests
erwei-xilinx Nov 1, 2024
26a111d
Revert "Re-enable air pipeline for cpu comparison tests"
erwei-xilinx Nov 1, 2024
947cb04
Remove comment after air is re-enabled
erwei-xilinx Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build_tools/ci/cpu_comparison/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,8 +537,8 @@ def aie_vs_llvm_cpu(
config,
test_file,
use_ukernel=False,
tile_pipeline="pack-peel",
lower_to_aie_pipeline="objectFifo",
tile_pipeline="pad-pack",
lower_to_aie_pipeline="air",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave the default as "pack-peel" and "objectFifo"? You can add a test for pad-pack pipeline if you like, but I think the current tests are enough.

function_name=None,
seed=1,
rtol=1e-6,
Expand Down
23 changes: 13 additions & 10 deletions build_tools/ci/run_matmul_test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -556,16 +556,16 @@ run_matmul_test \
###################################################################

# TODO: re-enable after fixing in AIR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: You can delete this line.

# if [ -d "$VITIS" ]; then
# run_matmul_test \
# --name_prefix "ukern" \
# --lower_to_aie_pipeline "air" \
# --tile_pipeline "pad-pack" \
# --lhs_rhs_type "bf16" \
# --acc_type "f32" \
# --m "256" --k "256" --n "256" \
# --use_ukernel "1"
# fi
if [ -d "$VITIS" ]; then
run_matmul_test \
--name_prefix "ukern" \
--lower_to_aie_pipeline "air" \
--tile_pipeline "pad-pack" \
--lhs_rhs_type "bf16" \
--acc_type "f32" \
--m "256" --k "256" --n "256" \
--use_ukernel "1"
fi

# Example of a run with a group of 2+ matmuls. Currently this test is passed
# the flag '--num_repeat_runs 0" as there is currently an issue with the runtime if
Expand Down Expand Up @@ -593,20 +593,23 @@ run_matmul_test \

run_matmul_test \
--name_prefix "packPeel_i32" \
--lower_to_aie_pipeline "air" \
--tile_pipeline "pack-peel" \
--lhs_rhs_type "i32" \
--acc_type "i32" \
--m "64" --n "64" --k "128"

run_matmul_test \
--name_prefix "packPeel_bf16" \
--lower_to_aie_pipeline "air" \
--tile_pipeline "pack-peel" \
--lhs_rhs_type "bf16" \
--acc_type "f32" \
--m "512" --n "512" --k "512"

run_matmul_test \
--name_prefix "packPeel_t_bf16" \
--lower_to_aie_pipeline "air" \
--tile_pipeline "pack-peel" \
--lhs_rhs_type "bf16" \
--acc_type "f32" \
Expand Down
2 changes: 1 addition & 1 deletion third_party/mlir-air
Open in desktop
Submodule mlir-air updated 1 files
+14 −1 mlir/lib/Transform/AIRMiscPasses.cpp
Loading