feat: add learn content to the node.js website #6064

ovflowd · 2023-10-28T14:00:24Z

Description

This PR introduces the Learn Pages from nodejs.dev to the current nodejs.org website. Note that these pages aim too look differently with the Website Redesign, but for now they'll look the way they are.

This PR introduces updates on the SideNavigation Component to support nested items
This PR fixes and improves some CSS styles for the content/structure of the Website (Grid Display) (tested on mobile, tablet, desktop viewports)
This PR removes the deprecated and duplicated guides with the new Learn pages and add redirects to the Learn pages
This PR updates respective navigation entries, translation keys for the new Learn Pages

Screenshots

Validation

The new Learn Pages should work and look nice.

vercel · 2023-10-28T14:00:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 30, 2023 10:25am

github-actions · 2023-10-28T14:00:44Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟠 84	🟢 95	🟢 92	🟢 92	🔗
/en/about	🟢 100	🟢 92	🟢 92	🟢 92	🔗
/en/about/previous-releases	🟢 100	🟢 91	🟢 92	🟢 92	🔗
/en/download	🟢 100	🟢 92	🟢 92	🟢 92	🔗
/en/blog	🟢 99	🟢 92	🟢 92	🟢 92	🔗

ovflowd · 2023-10-28T14:01:43Z

cc @bmuenzenmeyer and @nodejs/nodejs-website (also if any collaborator is interested in checking this PR), note this PR is mostly a port of content from the nodejs.dev repository.

github-actions · 2023-10-28T14:02:54Z

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	95.41% (333/349)	77.21% (61/79)	93.05% (67/72)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
42	0 💤	0 ❌	0 🔥	7.171s ⏱️

canerakdas

I checked desktop/tablet and mobile resolution and added a few comments 🎉

styles/old/layout/main.css

components/SideNavigation.tsx

i18n/locales/en.json

bmuenzenmeyer · 2023-10-29T14:44:33Z

On a desktop view the ends of lines are being cut off

I couldn't recreate this - so will be giving my 👍

bmuenzenmeyer

approving as i know this unlocks more work and translations

Co-authored-by: canerakdas <[email protected]> Signed-off-by: Claudio W <[email protected]>

bmuenzenmeyer · 2023-10-29T15:56:47Z

I just actually read some of the content - using words like trendy are strangely editorial and I think warrant a full review.

ovflowd · 2023-10-30T09:29:59Z

I just actually read some of the content - using words like trendy are strangely editorial and I think warrant a full review.

Do you want me to wait for that audit, or can this be done in a follow-up PR?

bmuenzenmeyer · 2023-10-30T11:37:32Z

Do you want me to wait for that audit, or can this be done in a follow-up PR?

Applying https://github.com/nodejs/nodejs.org/blob/main/CONTENT_VS_CODE.md to this work, I think we should merge.

ovflowd · 2023-10-30T11:48:43Z

Do you want me to wait for that audit, or can this be done in a follow-up PR?

Applying https://github.com/nodejs/nodejs.org/blob/main/CONTENT_VS_CODE.md to this work, I think we should merge.

Right, but that doesnt impede us from self reviewing content in future PRs. Most of this content was written around 2019-2020.

ovflowd added 11 commits October 28, 2023 15:53

feat: sidenav support recursive items

a6800e4

feat: added learn layout

5bd8711

feat: added learn navigation

af5df01

feat: added new translation ids

39311f0

feat: mark docs as archive

ed16263

chore: improved styles, use grid system

c588e1d

feat: added learn pages, removed duplicated/outdated guides

7e20159

chore: added images

c43595f

meta: crowdin no translations for learn

6ced836

chore: updated redirects

7a012cd

meta: no need of package-name for private package

19b8d53

ovflowd added i18n Issues/PRs related to the Website Internationalisation website redesign Issue/PR part of the Node.js Website Redesign infrastructure Issues/PRs related to the Repository Infra labels Oct 28, 2023

ovflowd requested review from a team as code owners October 28, 2023 14:00

ovflowd changed the title ~~feat: sidenav support recursive items~~ feat: add learn content to the node.js website Oct 28, 2023

This comment was marked as outdated.

Sign in to view

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 28, 2023

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 28, 2023

ovflowd deployed to Storybook October 28, 2023 14:00 — with GitHub Actions View deployment

nodejs deleted a comment from github-actions bot Oct 28, 2023

bmuenzenmeyer mentioned this pull request Oct 28, 2023

Create Navbar Component #6060

Closed

canerakdas reviewed Oct 28, 2023

View reviewed changes

styles/old/layout/main.css Outdated Show resolved Hide resolved

styles/old/layout/main.css Outdated Show resolved Hide resolved

components/SideNavigation.tsx Outdated Show resolved Hide resolved

bmuenzenmeyer reviewed Oct 28, 2023

View reviewed changes

i18n/locales/en.json Outdated Show resolved Hide resolved

This comment was marked as outdated.

Sign in to view

bmuenzenmeyer self-requested a review October 29, 2023 14:45

bmuenzenmeyer approved these changes Oct 29, 2023

View reviewed changes

AugustinMauroy approved these changes Oct 29, 2023

View reviewed changes

Apply suggestions from code review

bb3abd8

Co-authored-by: canerakdas <[email protected]> Signed-off-by: Claudio W <[email protected]>

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 29, 2023

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 29, 2023

ovflowd deployed to Storybook October 29, 2023 15:38 — with GitHub Actions View deployment

vercel bot deployed to Preview October 29, 2023 15:38 View deployment

style: use flexboxes

b89fc95

This comment was marked as outdated.

Sign in to view

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 29, 2023

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 29, 2023

ovflowd deployed to Storybook October 29, 2023 15:55 — with GitHub Actions View deployment

vercel bot deployed to Preview October 29, 2023 15:55 View deployment

canerakdas approved these changes Oct 29, 2023

View reviewed changes

chore: self-code-review and adjustments

22d12ce

vercel bot deployed to Preview October 30, 2023 10:25 View deployment

ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Oct 30, 2023

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Oct 30, 2023

ovflowd deployed to Storybook October 30, 2023 10:39 — with GitHub Actions View deployment

ovflowd added this pull request to the merge queue Oct 30, 2023

Merged via the queue into main with commit c72dc04 Oct 30, 2023
15 checks passed

ovflowd deleted the feat/learn-pages branch October 30, 2023 11:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add learn content to the node.js website #6064

feat: add learn content to the node.js website #6064

ovflowd commented Oct 28, 2023

vercel bot commented Oct 28, 2023 •

edited

Loading

This comment was marked as outdated.

github-actions bot commented Oct 28, 2023 •

edited

Loading

ovflowd commented Oct 28, 2023

github-actions bot commented Oct 28, 2023 •

edited

Loading

canerakdas left a comment

This comment was marked as outdated.

bmuenzenmeyer commented Oct 29, 2023

bmuenzenmeyer left a comment

This comment was marked as outdated.

bmuenzenmeyer commented Oct 29, 2023

ovflowd commented Oct 30, 2023

bmuenzenmeyer commented Oct 30, 2023

ovflowd commented Oct 30, 2023

feat: add learn content to the node.js website #6064

feat: add learn content to the node.js website #6064

Conversation

ovflowd commented Oct 28, 2023

Description

Screenshots

Validation

vercel bot commented Oct 28, 2023 • edited Loading

This comment was marked as outdated.

github-actions bot commented Oct 28, 2023 • edited Loading

ovflowd commented Oct 28, 2023

github-actions bot commented Oct 28, 2023 • edited Loading

Unit Test Coverage Report

Unit Test Report

canerakdas left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

bmuenzenmeyer commented Oct 29, 2023

bmuenzenmeyer left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

bmuenzenmeyer commented Oct 29, 2023

ovflowd commented Oct 30, 2023

bmuenzenmeyer commented Oct 30, 2023

ovflowd commented Oct 30, 2023

vercel bot commented Oct 28, 2023 •

edited

Loading

github-actions bot commented Oct 28, 2023 •

edited

Loading

github-actions bot commented Oct 28, 2023 •

edited

Loading