Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/aria label is missing #6417

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Fix/aria label is missing #6417

merged 5 commits into from
Mar 4, 2024

Conversation

marwan-mohamed12
Copy link
Contributor

@marwan-mohamed12 marwan-mohamed12 commented Mar 3, 2024 •
edited
Loading

For Details See #6414

  • added the aria-label for the RSS link
  • added the translation key for RSS link in en.json

@marwan-mohamed12 marwan-mohamed12 requested a review from a team as a code owner March 3, 2024 15:31
@vercel Vercel
Copy link

vercel bot commented Mar 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 4, 2024 11:36am

@marwan-mohamed12 marwan-mohamed12 mentioned this pull request Mar 3, 2024
Closed
@marwan-mohamed12
Copy link
Contributor Author

@AugustinMauroy
I've added the suggested modifications

AugustinMauroy
AugustinMauroy reviewed Mar 4, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cloud you rename i18n key and put at correct area in en.json
layouts.blog.subtitle -> components.blog.blogHeader.subtitle
layouts.blog.blogHeader.RSS -> ``components.blog.blogHeader.rssLink`

And after that it's will be perfect

@AugustinMauroy AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024 •
edited
Loading

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 96 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 96 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 95 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 95 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 96 🟢 100 🟢 92 🔗

AugustinMauroy
AugustinMauroy approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Thanks for your contribution 😄

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
 80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.453s ⏱️

@marwan-mohamed12
Copy link
Contributor Author

LGTM !!! Thanks for your contribution 😄

Happy to help 😄

@ovflowd ovflowd added this pull request to the merge queue Mar 4, 2024
Merged via the queue into nodejs:main with commit 8268bfe Mar 4, 2024
15 checks passed
@AugustinMauroy AugustinMauroy mentioned this pull request Mar 4, 2024
Closed
@marwan-mohamed12 marwan-mohamed12 deleted the fix/aria-label-is-missing branch March 4, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@ovflowd ovflowd ovflowd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marwan-mohamed12 @ovflowd @AugustinMauroy