Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/aria label is missing #6417

Merged
merged 5 commits into from
Mar 4, 2024
Merged

Fix/aria label is missing #6417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3db7702
feat: added the aria-lable for the RSS link
marwan-mohamed12 Mar 3, 2024
c62fde0
feat: added the translation key for RSS link in blogHeader
marwan-mohamed12 Mar 3, 2024
521805c
Merge branch 'nodejs:main' into fix/aria-label-is-missing
marwan-mohamed12 Mar 3, 2024
bb6137e
fix: add subtitles directly to aria-label
marwan-mohamed12 Mar 3, 2024
836ddea
fix: renamed i18n keys and updated en.json
marwan-mohamed12 Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions components/Blog/BlogHeader/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,14 @@ const BlogHeader: FC<BlogHeaderProps> = ({ category }) => {
<header className={styles.blogHeader}>
<h1>
{t('layouts.blog.title')}
<Link href={`/feed/${currentFile}`}>
<Link
href={`/feed/${currentFile}`}
aria-label={t('components.blog.blogHeader.rssLink')}
>
<RssIcon />
</Link>
</h1>
<p>{t('layouts.blog.subtitle')}</p>
<p>{t('components.blog.blogHeader.subtitle')}</p>
</header>
);
};
Expand Down
7 changes: 6 additions & 1 deletion i18n/locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,12 @@
"searchPage": {
"title": "You're searching: {query}"
}
},
"blog": {
"blogHeader": {
"subtitle": "The latest Node.js news, case studies, tutorials, and resources.",
"rssLink": "RSS feed"
}
}
},
"layouts": {
Expand All @@ -237,7 +243,6 @@
},
"blog": {
"title": "Blog",
"subtitle": "The latest Node.js news, case studies, tutorials, and resources.",
"selectCategory": "Categories",
"categories": {
"all": "Everything",
Expand Down
Loading