Fix QualifiedOffset.from_event
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomerShor
approved these changes
Sep 22, 2024
TomerShor
requested changes
Sep 22, 2024
TomerShor
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jira - https://iguazio.atlassian.net/browse/NUC-267
This PR partly changes back the changes done in https://github.com/nuclio/nuclio-sdk-py/pull/46/files, because in the latest nuclio versions v3io stream's path is in
event.topic, not inevent.pathas it used to be before. In order to support both older and newer versions, resolving logic has been added which will take path value if topic isn't passed.