Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QualifiedOffset.from_event #70

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Fix QualifiedOffset.from_event #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8f350d
Fix `QualifiedOffset.from_event`
rokatyy Sep 20, 2024
6d4d91f
Fix `QualifiedOffset.from_event`
rokatyy Sep 20, 2024
59d633b
ut
rokatyy Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion nuclio_sdk/qualified_offset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ def __init__(self, topic, partition, offset):

@staticmethod
def from_event(event):
return QualifiedOffset(event.path, event.shard_id, event.offset)
# topic resolving required to keep BC (NUC-233)
topic = event.topic if event.topic else event.path
return QualifiedOffset(topic, event.shard_id, event.offset)

def compile_explicit_ack_message(self):
"""
Expand Down
7 changes: 7 additions & 0 deletions nuclio_sdk/test/test_qualified_offset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,13 @@ def test_compile_explicit_ack_message(self):
actual_explicit_ack_message = qualified_offset.compile_explicit_ack_message()
self.assertEqual(expected_explicit_ack_message, actual_explicit_ack_message)

# check that if topic is passed, it takes precedence
event.topic = "topic"
expected_explicit_ack_message["attributes"]["topic"] = "topic"
qualified_offset = nuclio_sdk.QualifiedOffset.from_event(event)
actual_explicit_ack_message = qualified_offset.compile_explicit_ack_message()
self.assertEqual(expected_explicit_ack_message, actual_explicit_ack_message)

def _check_equal_qualified_offsets(self, expected, actual):
self.assertEqual(expected.topic, actual.topic)
self.assertEqual(expected.partition, actual.partition)
Expand Down
Loading