fix: remove newlines when truncating text #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iowillhoit
reviewed
Oct 4, 2024
| const text = cliTruncate(valueWithNoZeroWidthChars, spaceForText, {position: determineTruncatePosition(overflow)}) | ||
| const text = cliTruncate(valueWithNoZeroWidthChars.replaceAll('\n', ' '), spaceForText, { | ||
| position: determineTruncatePosition(overflow), | ||
| }) |
There was a problem hiding this comment.
It would be good to create a simple test for this newline replacement so we don't have a regression later.
Also, unrelated: this uncovered an issue with align-center where the first line is not centered.
Wrap (aligned center)
┌───────┬─────────┬─────┬───────────────────────────────────────────────────────────────────────────┐
│ Id │ Name │ Age │ Description │
├───────┼─────────┼─────┼───────────────────────────────────────────────────────────────────────────┤
│ 36329 │ Alice │ 20 │ Lorem ipsum dolor sit amet, consectetur │
│ │ │ │ adipi │
│ │ │ │ scing elit. Sed do eiusmod tempor incididunt ut labore et dolore magna │
│ │ │ │ aliqua. │
├───────┼─────────┼─────┼───────────────────────────────────────────────────────────────────────────┤
│ 49032 │ Bob │ 21 │ Lorem ipsum dolor sit amet, consectetur │
│ │ │ │ adipi │
│ │ │ │ scing elit. Sed do eiusmod tempor incididunt ut labore et dolore magna │
│ │ │ │ aliqua. │
├───────┼─────────┼─────┼───────────────────────────────────────────────────────────────────────────┤
│ 51786 │ Charlie │ 22 │ Lorem ipsum dolor sit amet, consectetur │
│ │ │ │ adipi │
│ │ │ │ scing elit. Sed do eiusmod tempor incididunt ut labore et dolore magna │
│ │ │ │ aliqua. │
└───────┴─────────┴─────┴───────────────────────────────────────────────────────────────────────────┘
iowillhoit
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.