fix(daily_round): added field level validation

ohcnetwork · Feb 27, 2024 · b8da013 · b8da013
1 parent 4daf666
commit b8da013
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 19 deletions.
diff --git a/care/facility/api/serializers/daily_round.py b/care/facility/api/serializers/daily_round.py
@@ -50,7 +50,11 @@ class DailyRoundSerializer(serializers.ModelSerializer):
         required=False,
     )
     temperature = serializers.DecimalField(
-        max_digits=5, decimal_places=2, required=True
+        max_value=106,
+        min_value=95,
+        max_digits=5,
+        decimal_places=2,
+        required=True,
     )
     review_interval = serializers.IntegerField(
         source="consultation__review_interval", required=False
@@ -350,12 +354,6 @@ def validate(self, attrs):
                         }
                     )
 
-        if "temperature" in validated:
-            if validated["temperature"] < 95 or validated["temperature"] > 106:
-                raise ValidationError(
-                    {"temperature": ["This field value must be between 95 and 106."]}
-                )
-
         if "additional_symptoms" in validated:
             if SymptomChoiceDict["OTHERS"] in validated["additional_symptoms"]:
                 if "other_symptoms" not in validated:

diff --git a/care/facility/tests/test_patient_daily_rounds_api.py b/care/facility/tests/test_patient_daily_rounds_api.py
@@ -14,19 +14,11 @@ def setUpTestData(cls) -> None:
         cls.district = cls.create_district(cls.state)
         cls.local_body = cls.create_local_body(cls.district)
         cls.super_user = cls.create_super_user("su", cls.district)
-        cls.facility = cls.create_facility(
-            cls.super_user, cls.district, cls.local_body
-        )
-        cls.user = cls.create_user(
-            "staff1", cls.district, home_facility=cls.facility
-        )
-        cls.patient = cls.create_patient(
-            district=cls.district, facility=cls.facility
-        )
+        cls.facility = cls.create_facility(cls.super_user, cls.district, cls.local_body)
+        cls.user = cls.create_user("staff1", cls.district, home_facility=cls.facility)
+        cls.patient = cls.create_patient(district=cls.district, facility=cls.facility)
         cls.asset_location = cls.create_asset_location(cls.facility)
-        cls.bed = cls.create_bed(
-            facility=cls.facility, location=cls.asset_location
-        )
+        cls.bed = cls.create_bed(facility=cls.facility, location=cls.asset_location)
         cls.consultation_without_bed = cls.create_consultation(
             facility=cls.facility, patient=cls.patient
         )