fix: Update validation for Daily Round form #1898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1898 +/- ##
===========================================
- Coverage 62.19% 62.07% -0.13%
===========================================
Files 221 221
Lines 12203 12235 +32
Branches 1742 1755 +13
===========================================
+ Hits 7590 7595 +5
- Misses 4305 4329 +24
- Partials 308 311 +3 ☔ View full report in Codecov by Sentry. |
|
@sainak Can you check the PR? |
sainak
reviewed
Feb 26, 2024
Comment on lines
345
to
429
| if "temperature" in validated: | ||
| if validated["temperature"] < 95 or validated["temperature"] > 106: | ||
| raise ValidationError( | ||
| {"temperature": ["This field value must be between 95 and 106."]} | ||
| ) | ||
|
|
||
| if "additional_symptoms" in validated: | ||
| if SymptomChoiceDict["OTHERS"] in validated["additional_symptoms"]: | ||
| if "other_symptoms" not in validated: | ||
| raise ValidationError( | ||
| { | ||
| "other_symptoms": [ | ||
| "This field is required if OTHERS is selected in Additional Symptoms." | ||
| ] | ||
| } | ||
| ) |
|
@aeswibon missing validation for other fields |
aeswibon
force-pushed
the
issue#1775
branch
2 times, most recently
from
698a2c1
to
1f4c3e0
Compare
|
@sainak I have added the validation |
sainak
added
the
to-be-closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Proposed Changes
Merge Checklist
/docsOnly PR's with test cases included and passing lint and test pipelines will be reviewed
@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins