Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset location route: modifications for CNS #2545

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

Jacobjeevan
Copy link

Proposed Changes

  • Added a boolean filter to asset location route (used by Location dropdown)
    • Query parameter to filter for locations with/without consultation beds
  • For CNS, fetch only location with registered monitors

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@ohcnetwork/care-backend-maintainers @ohcnetwork/care-backend-admins

- Add a parameter to filter for locations with no monitors
	- Also filter for monitors without paitents
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 17, 2024 12:51
@Jacobjeevan Jacobjeevan marked this pull request as draft October 17, 2024 12:53
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (0fc5260) to head (4d363ab).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2545      +/-   ##
===========================================
+ Coverage    65.62%   65.64%   +0.02%     
===========================================
  Files          223      223              
  Lines        13398    13408      +10     
  Branches      1856     1857       +1     
===========================================
+ Hits          8792     8802      +10     
  Misses        4222     4222              
  Partials       384      384              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jacobjeevan Jacobjeevan marked this pull request as ready for review October 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant