Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNS: filter by locations changes #8812

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Jacobjeevan
Copy link
Contributor

@Jacobjeevan Jacobjeevan commented Oct 17, 2024

Proposed Changes

image image

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for care-ohc ready!

Name Link
🔨 Latest commit 5f0e0a8
🔍 Latest deploy log https://app.netlify.com/sites/care-ohc/deploys/6710c04d81a05b0008156ede
😎 Deploy Preview https://deploy-preview-8812--care-ohc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Jacobjeevan
Copy link
Contributor Author

Jacobjeevan commented Oct 17, 2024

So we do need to make an extra change, consider the following scenario:

  • There are two locations (one with monitors with patients, one for monitors without).
image image

Now, consider following behavior.

(1) User selects "Include monitors without patients"
(2) Filters for location "Camera Locations" (which is only available under monitors without patients)
(3) User unchecks monitors without patients

At present, the filter form selection stays the same (resulting in No vitals screen, which is not accurate), so we need to reset the location selection whenever user marks/unmarks the checkbox.

@rithviknishad I'm wondering if there's a way to do that without touching LocationSelect?

@Jacobjeevan Jacobjeevan added the question Further information is requested label Oct 17, 2024
@Jacobjeevan Jacobjeevan marked this pull request as ready for review October 17, 2024 12:59
@Jacobjeevan Jacobjeevan requested a review from a team as a code owner October 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In CNS page: filter by location- hide locations with no Monitors
1 participant