-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add field validation to resolve the Update Profile Issue #8809
Open
JavidSumra
wants to merge
9
commits into
ohcnetwork:develop
Choose a base branch
from
JavidSumra:issues/8804/profile-update-validation
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add field validation to resolve the Update Profile Issue #8809
JavidSumra
wants to merge
9
commits into
ohcnetwork:develop
from
JavidSumra:issues/8804/profile-update-validation
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bodhish
requested changes
Oct 17, 2024
…t for cleaner comparison logic
rithviknishad
requested changes
Oct 17, 2024
…vidSumra/care_fe into issues/8804/profile-update-validation
rithviknishad
approved these changes
Oct 17, 2024
@JavidSumra fix the failing cypress test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces logic to disable the "Update" button on the profile update page when no changes are detected in the form fields. The useMemo hook compares the current form values with the user's existing data and detects any modifications.
@ohcnetwork/care-fe-code-reviewers
Demo Video
Click here to watch the demo video
Merge Checklist