Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add field validation to resolve the Update Profile Issue #8809

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Add field validation to resolve the Update Profile Issue #8809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7fff299
Add field validation to resolve the Update Profile Issue
JavidSumra Oct 17, 2024
5fee85e
refactor(profile): migrated change detection from useMemo to useEffec…
JavidSumra Oct 17, 2024
7b775a3
Discard package-lock.json file
JavidSumra Oct 17, 2024
391dcab
fix: prevent isDirty from updating on load due to phone number valida…
JavidSumra Oct 17, 2024
e39adc5
removed unnecessary console logging
JavidSumra Oct 17, 2024
34f6bbb
Merge branch 'develop' into issues/8804/profile-update-validation
JavidSumra Oct 17, 2024
1c3c769
fix: removed 'useEffect' from 'PhoneNumberFormField.tsx' Component
JavidSumra Oct 17, 2024
b2735fc
Merge branch 'issues/8804/profile-update-validation' of github.com:Ja…
JavidSumra Oct 17, 2024
217ae44
Merge branch 'develop' into issues/8804/profile-update-validation
nihal467 Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/Components/Form/FormFields/PhoneNumberFormField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,6 @@ export default function PhoneNumberFormField(props: Props) {
}
}, [setValue]);

useEffect(() => {
setValue(field.value || "+91");
}, []);

return (
<FormField
field={{
Expand Down
9 changes: 8 additions & 1 deletion src/Components/Users/UserProfile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export default function UserProfile() {
isChecking: false,
isUpdateAvailable: false,
});
const [dirty, setDirty] = useState<boolean>(false);

const authUser = useAuthUser();

Expand Down Expand Up @@ -172,6 +173,7 @@ export default function UserProfile() {
type: "set_form",
form: formData,
});
setDirty(false);
},
});

Expand Down Expand Up @@ -324,6 +326,7 @@ export default function UserProfile() {
type: "set_form",
form: { ...states.form, [event.name]: event.value },
});
setDirty(true);
};

const getDate = (value: any) =>
Expand Down Expand Up @@ -788,7 +791,11 @@ export default function UserProfile() {
</div>
</div>
<div className="bg-secondary-50 px-4 py-3 text-right sm:px-6">
<Submit onClick={handleSubmit} label={t("update")} />
<Submit
onClick={handleSubmit}
label={t("update")}
disabled={!dirty}
/>
</div>
</div>
</form>
Expand Down
Loading