New Patient Search and Register UI #9400
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThis pull request introduces comprehensive updates across multiple components of a healthcare application. The changes span dependency version updates, internationalization improvements, UI component enhancements, and patient management functionalities. Key modifications include introducing new components like Changes
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Deploying care-fe with
|
| Latest commit: |
4c03487
|
| Status: | ⚡️ Build in progress... |
|
👋 Hi, @shivankacker, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Bug ReportMajor Functionality
Minor Functionality
Question needs clarification
|
|
@nihal467 we are not including insurance and volunteer details right now.
|
|
Made all changes, except :
This will add a lot of translations to manage. The label of the field is sufficient enough i think
I let it be as what it already was (specified in translations)
Will completely replace with a new phone number field after this PR.
Will fix these later |
|
👋 Hi, @shivankacker, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Fix the below Issue before requesting another review
Issue that can be taken in another PR
Question
|
| csv: true, | ||
| facility: qParams.facility, | ||
| }; | ||
| delete qParams.is_active; |
There was a problem hiding this comment.
@shivankacker Can you get this resolved? What exactly are you achieving with the delete here?
| }; | ||
|
|
||
| useEffect(() => { | ||
| const timeout = setTimeout( |
| const handleFormSubmit = (e: React.FormEvent<HTMLFormElement>) => { | ||
| e.preventDefault(); | ||
| const errors: Record<string, string[]> = {}; | ||
| const requiredFields: Array<keyof typeof form> = [ |
There was a problem hiding this comment.
These should move to a patient.ts file where the PatientModel and the patientCreateValidator should exist
| }; | ||
| }, [form.phone_number]); | ||
|
|
||
| const patientPhoneSearch = useQuery({ |
There was a problem hiding this comment.
I think a better workflow would be to freeze the phoneNumber field in the PatientRegister Form, given that the user has already gone through the search and find phase.
Maybe file an issue
There was a problem hiding this comment.
Are you suggesting to freeze the input field with a number if specified in query params?
flow will be : user searches for phone number xyz, finds no patients, clicks on create patient which takes the user to /patient-register?number=xyz with a frozen number field
- What happens if the user had initially searched for the wrong phone number, and now wants to change it midway through filling the form?
- It would still need a patient phone search for cases where patient is being created without searching for the number first, so functionality would not change.
|
👋 Hi, @shivankacker, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
|
|
Bug ReportMinor
Enhancement
|
|
@shivankacker look into the above comment CC: @bodhish |
|
@nihal467
Covered in #9552
Covered In #9553
Covered In #9552
Do we really need it? Specifying both a placeholder and label here will not make a lot of sense + it would mean more translations to manage |
|
@shivankacker Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
|
|
Proposed Changes
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
New Features
SectionNavigatorcomponent for improved navigation within sections.PatientIndexandPatientRegistrationcomponents for enhanced patient management and registration.FacilityListandManagePatientscomponents.Enhancements
Bug Fixes
Chores