Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Align Bioportal and AgroPortal - part 1 - Configuration code and Docker #21

Merged

Conversation

syphax-bouazzouni
Copy link
Contributor

@syphax-bouazzouni syphax-bouazzouni commented Oct 10, 2024

Changes

  • Add docker development environment for the UI, run bin/ontoportal dev --api-key <any valid apikey> --api-url https://data.bioontology.org to run UI code locally.
  • Clean unused gems from Gemfile (Removed cube-ruby, flamegraph, open_uri_redirections, psych, rexml, stackprof, thin, and some others)
  • Migrated to Puma for development, instead of thin

app/controllers/users_controller.rb Dismissed Show dismissed Hide dismissed
app/views/concepts/_details.html.haml Dismissed Show dismissed Hide dismissed
@syphax-bouazzouni syphax-bouazzouni marked this pull request as draft October 10, 2024 08:24
@syphax-bouazzouni syphax-bouazzouni changed the title Feauture: Align Bioportal and Agroportal - part 1 - Configuration code Feauture: Align Bioportal and AgroPortal - part 1 - Configuration code Oct 10, 2024
@syphax-bouazzouni syphax-bouazzouni marked this pull request as ready for review October 10, 2024 08:51
@syphax-bouazzouni syphax-bouazzouni changed the title Feauture: Align Bioportal and AgroPortal - part 1 - Configuration code Feauture: Align Bioportal and AgroPortal - part 1 - Configuration code and Docker Oct 10, 2024
@syphax-bouazzouni syphax-bouazzouni changed the title Feauture: Align Bioportal and AgroPortal - part 1 - Configuration code and Docker Feature: Align Bioportal and AgroPortal - part 1 - Configuration code and Docker Oct 11, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the BioPortal team need miniprofile?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miniprofiler can be added back if it's needed. The vast majority of the latency in the UI is because of the API.

@@ -22,6 +22,8 @@ shared:
virtual_appliance: 'https://ontoportal.github.io/documentation/administration'
widgets: 'http://www.bioontology.org/wiki/NCBO_Widgets'
wiki: 'https://www.bioontology.org/wiki/'
mappings: 'https://www.bioontology.org/wiki/BioPortal_Help#Mappings_Tab'
metadata_help: 'https://doc.jonquetlab.lirmm.fr/share/32c082ff-97f5-45f4-bafe-05f41c9a5ce4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata_help points to a page that redirects to industryportal's submission-guide.
Is there a plan to make this more generic?

@alexskr
Copy link
Contributor

alexskr commented Oct 17, 2024

/= link application-esbuild.js needs to be added to app/assets/config/manifest.js

@alexskr alexskr merged commit 27208dc into ontoportal:master Oct 17, 2024
2 checks passed
alexskr added a commit to ncbo/bioportal_web_ui that referenced this pull request Oct 18, 2024
The pull request ontoportal#21 removed files that this class depends on. This is a temporary workaround until #337 is implemented.
@alexskr
Copy link
Contributor

alexskr commented Oct 18, 2024

This PR removes/unpins rexml and base64 gems; however, UI doesn't start in production with ruby 3.0 and apache+passenger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants