change admission review to v1 #139
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold it is a test PR to use v1 admissionReview |
qiujian16
force-pushed
the
admisionreview-v1
branch
from
811d195
to
57e4128
Compare
qiujian16
force-pushed
the
admisionreview-v1
branch
from
57e4128
to
ae1f46a
Compare
Signed-off-by: Jian Qiu <[email protected]>
qiujian16
force-pushed
the
admisionreview-v1
branch
from
ae1f46a
to
b4e1b91
Compare
|
/retest |
| @@ -30,10 +30,10 @@ func (a *ManagedClusterMutatingAdmissionHook) MutatingResource() (schema.GroupVe | |||
| } | |||
|
|
|||
| // Admit is called by generic-admission-server when the registered REST resource above is called with an admission request. | |||
| func (a *ManagedClusterMutatingAdmissionHook) Admit(req *admissionv1beta1.AdmissionRequest) *admissionv1beta1.AdmissionResponse { | |||
| func (a *ManagedClusterMutatingAdmissionHook) Admit(req *admissionv1.AdmissionRequest) *admissionv1.AdmissionResponse { | |||
There was a problem hiding this comment.
I think you want to have this release of your admission webhook handle both v1beta1 admissionreview and v1 admissionreview. Allowing both will allow you to update the webhook server first and the admission registration second. Probably in two different releases.
- release current - registration v1beta1 review, server v1beta1 review
- current +1 - registration v1beta1 review, server v1 and v1beta1 review
- current +2 - registration v1 review, server v1 and v1beta1 review
- current +3 - registration v1 review, server v1 review
|
@qiujian16: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Jian Qiu [email protected]