refactor: spec_finder.py

[prnam]

This PR

• applies ruff format
• adds missing docstrings for main
• uses %s formatting in logging functions
• adds encoding
• refactors extract_spec_map & parse_rust_files code from main
• refactors get_spec function
• adds logging config
• adds docstrings for _demarkdown & get_spec function
• improves message sentence

Notes

Also, fixes parsing error for the specification.json

[gruebel]

hey @prnam thanks for the contribution, but there are too many unrelated changes in one PR, which makes it tedious to review. For example, don't apply a radical formatting, which changes mostly single quotes strings to double quotes. This is just a helper script, not really sure it needs proper logging or docstrings. Please create separate PRs for a subset of changes, then it can be reviewed better.

[prnam]

hey @prnam thanks for the contribution, but there are too many unrelated changes in one PR, which makes it tedious to review. For example, don't apply a radical formatting, which changes mostly single quotes strings to double quotes. This is just a helper script, not really sure it needs proper logging or docstrings. Please create separate PRs for a subset of changes, then it can be reviewed better.

Hey @gruebel
Could you please go through each commit one at a time?

This will help you understand how each change builds on the previous one and how it relates to the refactoring of this Python file.

[beeme1mr]

@justinabrahms you may be interested in this one 😄

[prnam]

@justinabrahms you may be interested in this one 😄

If it still requires separate PR, then let me know which should be separate ones among the commits, so that I can raise it separately with approved list of type prefix. Thanks in advance. 🙂

[justinabrahms]

I like a lot of the changes in here. Unfortunately, I'm hoping that we can delete the spec_finder.py repo entirely in favor of a docker image that's used across languages. See #73. The new specfinder code is at https://github.com/open-feature/spec/tree/main/tools/specification_parser

[justinabrahms]

Just a note that this lost it's preceeding whitespace, which my fuzzy memory tells me wsa to help with visual parsing of the output.

[justinabrahms]

I would personally not introduce the logging module. It's too heavy weight for CLI output, imo.

[justinabrahms]

I don't see this in the new code.