Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: spec_finder.py #89

Closed
wants to merge 10 commits into from
Closed

refactor: spec_finder.py #89

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a3ce49b
improve message sentence
prnam Sep 21, 2024
d2139b9
add docstrings for _demarkdown & get_spec function
prnam Sep 21, 2024
fab9fef
add logging config
prnam Sep 21, 2024
392a617
refactor get_spec function
prnam Sep 21, 2024
7463529
refactor extract_spec_map & parse_rust_files code from main
prnam Sep 21, 2024
0ca8919
add encoding
prnam Sep 21, 2024
f8844c8
use %s formatting in logging functions
prnam Sep 21, 2024
b20cf5e
add missing docstrings for main
prnam Sep 21, 2024
dc52d13
apply ruff format
prnam Sep 21, 2024
ec0a1f7
Merge branch 'main' into refactor/spec-finder-py
prnam Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions spec_finder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
#!/usr/bin/env python
import logging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally not introduce the logging module. It's too heavy weight for CLI output, imo.

import urllib.request
import json
import re
import difflib
import os
import sys

# Configure logging
logging.basicConfig(level=logging.INFO, format='%(levelname)s: %(message)s')

def _demarkdown(t):
"""Remove markdown-like formatting from text."""
return t.replace('**', '').replace('`', '').replace('"', '')
Expand Down