-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform action #15
Perform action #15
Conversation
… fixes in accessing dict Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
…ane distance in example config Signed-off-by: Aaron Chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments about things that I think should be changed, but also some suggestions that are just meant to be notes for potential future improvements.
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
Signed-off-by: Aaron Chong <[email protected]>
* First implementation of calling predefined variable move mission Signed-off-by: Aaron Chong <[email protected]> * added variable_move_mission field in example config, fixed mir_config Signed-off-by: Aaron Chong <[email protected]> * Add assert that start sets are not empty, and fix API usage for start.lane Signed-off-by: Aaron Chong <[email protected]> * Removed unused create move missions, fix use before declare Signed-off-by: Aaron Chong <[email protected]> * Docking using pre-defined mission, adding to example config Signed-off-by: Aaron Chong <[email protected]> * Changed variable_move_mission to more descriptive rmf_move_mission, updated all use cases as well, added additional documentation Signed-off-by: Aaron Chong <[email protected]> Signed-off-by: Aaron Chong <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
This adds support for
perform_action
, targeting specific mission names that have been predefined in the MiR dashboard, and can be listed in the config file to be called as aperform_action
task.