Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[otelcol] add converters to components command #12385

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jackgopack4
Copy link
Contributor

@jackgopack4 jackgopack4 commented Feb 13, 2025

Description

Adds list of Converters to command components. Additionally, if this is accepted, Converters must now implement Type() function as part of interface. Given that there are no public converters in core or contrib repos, I didn't feel like this would be a controversial change, and it would be very easy for any private users of this interface to update their code to support it.

Link to tracking issue

Extends #11900

Testing

added test data to tests added in 11900, added test to collector_test.go

Documentation

Changelog file

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (9ea6963) to head (5631f36).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12385   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         465      465           
  Lines       25285    25291    +6     
=======================================
+ Hits        23311    23317    +6     
  Misses       1575     1575           
  Partials      399      399           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackgopack4 jackgopack4 force-pushed the add-providers-converters-moduleinfo-command branch from e8050b4 to eaeb7df Compare February 13, 2025 19:23
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we split the two changes (adding converters and adding this to moduleInfo) into two separate PRs?

@jackgopack4
Copy link
Contributor Author

Can we split the two changes (adding converters and adding this to moduleInfo) into two separate PRs?

yes, no problem. I will make this into the "add converters to ModuleInfo" and split out adding the both of them to the ModuleInfos struct for a future PR after this one is merged.

@jackgopack4 jackgopack4 force-pushed the add-providers-converters-moduleinfo-command branch from eaeb7df to b482d6e Compare February 18, 2025 18:26
@jackgopack4 jackgopack4 changed the title add providers converters to moduleinfo and converters to component co… [otelcol] add converters to components command Feb 18, 2025
@jackgopack4 jackgopack4 force-pushed the add-providers-converters-moduleinfo-command branch from 4c6cc27 to 50eeec8 Compare February 18, 2025 18:50
@jackgopack4 jackgopack4 force-pushed the add-providers-converters-moduleinfo-command branch from 50eeec8 to 5631f36 Compare February 18, 2025 18:57
@jackgopack4 jackgopack4 marked this pull request as ready for review February 18, 2025 19:16
@jackgopack4 jackgopack4 requested a review from a team as a code owner February 18, 2025 19:16
@jackgopack4
Copy link
Contributor Author

I have removed the "add providers and converters to ModuleInfos struct" portions of the PR and limited this PR to just adding Converters to components command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants