-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[otelcol] add converters to components command #12385
base: main
Are you sure you want to change the base?
[otelcol] add converters to components command #12385
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12385 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 465 465
Lines 25285 25291 +6
=======================================
+ Hits 23311 23317 +6
Misses 1575 1575
Partials 399 399 ☔ View full report in Codecov by Sentry. |
e8050b4
to
eaeb7df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we split the two changes (adding converters and adding this to moduleInfo) into two separate PRs?
yes, no problem. I will make this into the "add converters to ModuleInfo" and split out adding the both of them to the ModuleInfos struct for a future PR after this one is merged. |
eaeb7df
to
b482d6e
Compare
4c6cc27
to
50eeec8
Compare
50eeec8
to
5631f36
Compare
I have removed the "add providers and converters to ModuleInfos struct" portions of the PR and limited this PR to just adding Converters to components command |
Description
Adds list of Converters to command
components
. Additionally, if this is accepted, Converters must now implementType()
function as part of interface. Given that there are no public converters in core or contrib repos, I didn't feel like this would be a controversial change, and it would be very easy for any private users of this interface to update their code to support it.Link to tracking issue
Extends #11900
Testing
added test data to tests added in 11900, added test to collector_test.go
Documentation
Changelog file