-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(semantic-conventions): update semantic conventions to v1.29.0 #5356
Conversation
This also adds a changelog-gen.js script to help generate meaningful summary of changes in the semconv JS package. Note: This change *excludes* the new 'network.interface.name' attribute because of open-telemetry/semantic-conventions#1777
In the last semconv update PR we discussed some generation of better changelogs for semconv updates. This PR adds a script to help with that. The result is in the diff of semantic-conventions/CHANGELOG.md
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5356 +/- ##
=======================================
Coverage 94.79% 94.79%
=======================================
Files 310 310
Lines 7974 7974
Branches 1682 1682
=======================================
Hits 7559 7559
Misses 415 415 |
A comment/suggestion on the changelog entry formatting from an OTel JS maintainers call earlier today: Separate disclosures for each change type. "Added" change type at the bottom. |
…have an explicit stability; this is a more general fix to skip the current case (network.interface.name), per suggestion from Liudmila
Here is a gist showing an example rendering. Note that I've manually faked some of the unstable changes as "stable" changes, so we can see some data in that section. (The actual 1.29.0 change did not include any changes to stable exports.) https://gist.github.com/trentm/0decada22acd953813efb698a1985f29 In this rendering, both the stable and unstable sections are using the same |
… to help with grepping); update the changelog-gen script to support comparing older versions (e.g. changelog-gen.js 1.27.0 1.28.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this! I suggested a change to the usage comments, and had a question around usage when the local version is passed into the changelog script, but it's not blocking since I don't see it being a common use case and happy to hear what I did wrong 😄
const isPrevDeprecated = prevNames.has(k) && isDeprecated(prevSrc, k); | ||
const isCurrDeprecated = currNames.has(k) && isDeprecated(currSrc, k); | ||
if (isPrevDeprecated && !isCurrDeprecated) { | ||
throw new Error(`semconv export '${k}' was *un*-deprecated in this release!? Wassup?`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
semconv export '${k}' was *un*-deprecated in this release!? Wassup?
😄
Co-authored-by: Jamie Danielson <[email protected]>
Co-authored-by: Jamie Danielson <[email protected]>
…p the 'curl | tar' command so that a failed curl actually breaks there with a more meaningful message
…5356) Co-authored-by: Jamie Danielson <[email protected]>
Merge queue checks failed in
|
This also adds a changelog-gen.js script to help generate meaningful summary of changes in the semconv JS package.
Note: This change excludes the new 'network.interface.name' attribute because of open-telemetry/semantic-conventions#1777
Note: I did not update the weaver version to the latest. Doing so includes some whitespace fixes in the generated output that I wanted to do in a separate PR after this one.