feat: show whether the property is static #190
Merged
+95
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-viewer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bennypowers
requested changes
Oct 21, 2023
There was a problem hiding this comment.
This looks really good. I'd like it to be more obvious that a property is static, rather than adding the word static to the "type" column.
WDYT @web-padawan
bendera
force-pushed
the
feat/issue-151-static-properties
branch
from
2118fa8
to
6d79886
Compare
|
Sorry, I'm a bit confused. Who is the comment addressed to? Me or web-padavan? In the first case, which options should I choose? Include all packages + patch bump? |
|
it's a minor changeset on api-docs |
|
Done. I included the common package too because new theme variables were added. |
bennypowers
approved these changes
Oct 22, 2023
web-padawan
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the feature described in #151