[src/api] Update haml_lint 0.59.0 → 0.60.0 (major) #17328
+43
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
krauselukas
reviewed
Feb 7, 2025
danidoni
force-pushed
the
depfu/update/srcapi/haml_lint-0.60.0
branch
from
337d17d to
984bb2e
Compare
eduardoj
reviewed
Feb 10, 2025
| @@ -0,0 +1,28 @@ | |||
| require 'browser_helper' | |||
|
|
|||
| RSpec.describe 'Requests', :beta, :js, :vcr do | |||
There was a problem hiding this comment.
Suggested change
| RSpec.describe 'Requests', :beta, :js, :vcr do | |
| RSpec.describe 'Requests', :vcr do |
:beta and :js are implicit from the spec path. They can be removed.
Also, if :vcr is needed, we are missing the cassettes.
There was a problem hiding this comment.
:vcr is needed and you need the cassettes. The specs error out because there is no backend
danidoni
force-pushed
the
depfu/update/srcapi/haml_lint-0.60.0
branch
from
984bb2e to
c29e745
Compare
Fixed the haml linter rule InstanceVariables complaining about us using instance variables in partials that are not part of the breadcrumbs.
…d_role request type
danidoni
force-pushed
the
depfu/update/srcapi/haml_lint-0.60.0
branch
from
c29e745 to
3244aa2
Compare
|
@depfu rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ haml_lint (0.59.0 → 0.60.0) · Repo · Changelog
Release Notes
0.60.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 18 commits:
Cut version 0.60.0 (#546)Update InstanceVariables linter to support :ruby filters (#545)Update overcommit requirement from 0.64.1 to 0.65.0 (#544)Update rubocop requirement from 1.70.0 to 1.71.0 (#543)Re-run `appraisal install` to sync gemfiles/* versions (#542)Default to parallel true (#541)Update rubocop requirement from 1.69.2 to 1.70.0 (#539)Update rubocop-performance requirement from 1.23.0 to 1.23.1 (#538)Set `Layout/First_#{}_LineBreak` lints as disabled in rubocop config (#536)Enable rubocop rules this project is compliant with (#537)Update README to show that we run Appraisal on haml 5/6 not 4/5 (#535)Update rubocop requirement from 1.69.1 to 1.69.2 (#533)Update rubocop requirement from 1.69.0 to 1.69.1 (#532)Update rubocop requirement from 1.68.0 to 1.69.0 (#531)Update rubocop-performance requirement from 1.22.1 to 1.23.0 (#530)Update overcommit requirement from 0.64.0 to 0.64.1 (#528)Update rubocop requirement from 1.66.1 to 1.68.0 (#527)Update rspec-its requirement from ~> 1.0 to ~> 2.0 (#526)✳️ rubocop (1.71.0 → 1.71.1) · Repo · Changelog
Commits
See the full diff on Github. The new version differs by 60 commits:
Cut 1.71.1Update Changelog[Fix #13750] Fix false positives for `Style/RedundantSelfAssignment`[Fix #13751] Fix false positive in `Layout/ExtraSpacing` with `ForceEqualSignAlignment: true` for endless methodsMerge pull request #13780 from Earlopain/access-mod-numblockFix a false positive `Style/AccessModifierDeclarations` when using access modifier in a numblockFix `InternalAffairs/NodeTypeMultiplePredicates` offensesAdd `InternalAffairs/NodeTypeMultiplePredicates` to look for `and` or `or` conditions checking a node for / against multiple node typesMerge pull request #13778 from dvandersluis/remove-host-environment-simulation-helperRemove `HostEnvironmentSimulatorHelper`Merge pull request #13777 from Earlopain/empty-line-defs-numblockFix a false negative for `Layout/EmptyLineBetweenDefs` with `DefLikeMacros` and numblocksMerge pull request #13776 from koic/ping_jruby_9_4_10_0_on_ciPin JRuby 9.4.10.0 to prevent build error on JRuby 9.4.11.0Merge pull request #13775 from Earlopain/assign-cond-numblockFix a false positive for `Lint/AssignmentInCondition` when assigning in numblocksMerge pull request #13774 from koic/remove_gem_jar_dependencies_from_gemfileRemove workaround gem dependency from Gemfile for JRuby CI matrixMerge pull request #13773 from koic/fix_false_positive_for_layout_redundant_line_break_copFix false positives for `Layout/RedundantLineBreak`Merge pull request #13767 from dvandersluis/fix/identical-conditional-branches-assignmentMerge pull request #13771 from Earlopain/sole-nested-cond-numblockMerge pull request #13769 from Earlopain/redundant-parens-numblockMerge pull request #13768 from Earlopain/unreachable-code-numblocksFix wrong autocorrect for `Style/SoleNestedConditional` when using numblocksFix a false negative for `Style/RedundantParentheses` with numblocksFix a false positive for `Lint/UnreachableCode` with `instance_eval` numblockFix `Style/IdenticalConditionalBranches` autocorrect when condition is inside assignmentFix a false negative for `Lint/AmbiguousBlockAssociation` with numblocks[Fix #13745] Add new `InternalAffairs/NodePatternGroups` copFix a false positive for `Style/SuperArguments` when calling super in a numblockRemove dead code in `Style/ParallelAssignment`Fix a false negative for `Layout/SingleLineBlockChain` with numblocksMerge pull request #13760 from dvandersluis/fix/redudnant-source-rangMerge pull request #13759 from Earlopain/constant-definition-numblocksFix crash in `InternalAffairs/RedundantSourceRange` when `source_range` has no receiverFix a false negative for `Lint/ConstantDefinitionInBlock` with numblocksMerge pull request #13758 from Earlopain/traversal-methods-groupsUse node groups in traversal methodsRegister an offense for `Naming/BlockForwarding` and `Style/ArgumentsForwarding` with Ruby >= 3.4 when the block is referenced in a blockUse `Node#any_block_type?`Merge pull request #13748 from d4rky-pl/fix-missing-include[Fix #10081] Add the missing `include RuboCop::RSpec::ExpectOffense` in rubocop/rspec/support.rbMerge pull request #13754 from koic/enforce_single_line_only_for_rspec_example_without_descriptionUpdate `EnforcedStyle` of `RSpec/ExampleWithoutDescription`Revert "Update `EnforcedStyle` of `RSpec/ExampleWithoutDescription`"Update `EnforcedStyle` of `RSpec/ExampleWithoutDescription`[Docs] Tweak the docs for `Style/HashExcept` and `Style/HashSlice`[Fix #13739] Fix false positive for `Style/HashExcept` and `Style/HashSlice` when checking for inclusion with a rangeMerge pull request #13747 from kyanagi/quote_keywords[DOC] Quote keywordsMerge pull request #13746 from kyanagi/quote_with_backticks[DOC] Quote cop names and symbols with backticksMerge pull request #13743 from Earlopain/spellcheck-if-availableConfigure codespell for local usageMerge pull request #13742 from koic/revert_arm64_runners_on_ciRevert "CI: Use arm64 runners"Don't mark as stale issues and PRs with a milestoneIgnore bugs in issue staleness checksReset the Antora docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands